Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scheme for emitting errors without halting interpretation #1127

Merged
merged 12 commits into from
Jan 9, 2020

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 24, 2019

cc #797

@RalfJung

This comment has been minimized.

src/diagnostics.rs Outdated Show resolved Hide resolved
src/stacked_borrows.rs Outdated Show resolved Hide resolved
src/stacked_borrows.rs Outdated Show resolved Hide resolved
src/stacked_borrows.rs Outdated Show resolved Hide resolved
@oli-obk

This comment has been minimized.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 8, 2020

This is how it looks now:

Screenshot from 2020-01-08 13-03-50

@RalfJung
Copy link
Member

RalfJung commented Jan 8, 2020

So you managed to make it a "note", not an "error", nice. :)

src/diagnostics.rs Outdated Show resolved Hide resolved
src/diagnostics.rs Outdated Show resolved Hide resolved
src/diagnostics.rs Outdated Show resolved Hide resolved
src/stacked_borrows.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

RalfJung commented Jan 9, 2020

r=me, but it would be good to add doc comment to the public functions in diagnostics.rs.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 9, 2020

@bors r=RalfJung

@bors
Copy link
Contributor

bors commented Jan 9, 2020

📌 Commit dbffbe5 has been approved by RalfJung

bors added a commit that referenced this pull request Jan 9, 2020
Add a scheme for emitting errors without halting interpretation

cc #797
@bors
Copy link
Contributor

bors commented Jan 9, 2020

⌛ Testing commit dbffbe5 with merge a91f379...

@bors
Copy link
Contributor

bors commented Jan 9, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing a91f379 to master...

@bors bors merged commit dbffbe5 into master Jan 9, 2020
@oli-obk oli-obk deleted the stacked_borrow_tracing branch January 9, 2020 14:38
@RalfJung RalfJung mentioned this pull request Feb 21, 2020
bors added a commit that referenced this pull request Feb 22, 2020
fix README

With #1127, we do not abort execution any more when the tracked tag gets popped, we just show a backtrace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants