Add a scheme for emitting errors without halting interpretation #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Dec 26, 2019
RalfJung
reviewed
Dec 26, 2019
RalfJung
reviewed
Dec 26, 2019
RalfJung
reviewed
Dec 26, 2019
This comment has been minimized.
This comment has been minimized.
… to an `InterpCx`
oli-obk
force-pushed
the
stacked_borrow_tracing
branch
from
18272c6
to
90a8f2f
Compare
|
This is how it looks now:
|
|
So you managed to make it a "note", not an "error", nice. :) |
RalfJung
reviewed
Jan 8, 2020
RalfJung
reviewed
Jan 8, 2020
RalfJung
reviewed
Jan 8, 2020
oli-obk
force-pushed
the
stacked_borrow_tracing
branch
from
89b5a50
to
c69ebaa
Compare
RalfJung
reviewed
Jan 9, 2020
|
r=me, but it would be good to add doc comment to the public functions in |
|
@bors r=RalfJung |
|
📌 Commit dbffbe5 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 9, 2020
Add a scheme for emitting errors without halting interpretation cc #797
|
☀️ Test successful - checks-travis, status-appveyor |
Merged
bors
added a commit
that referenced
this pull request
Feb 22, 2020
fix README With #1127, we do not abort execution any more when the tracked tag gets popped, we just show a backtrace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #797