rustup; make tests pass again #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 4a03510 has been approved by |
RalfJung
commented
Jan 15, 2021
| @@ -824,8 +824,7 @@ impl VClockAlloc { | |||
| // Throw the data-race detection. | |||
| throw_ub_format!( | |||
| "Data race detected between {} on {} and {} on {}, memory({:?},offset={},size={})\ | |||
| \n\t\t -current vector clock = {:?}\ | |||
| \n\t\t -conflicting timestamp = {:?}", | |||
| \n(current vector clock = {:?}, conflicting timestamp = {:?})", | |||
There was a problem hiding this comment.
@JCTyblaidd I had to change your messages here since rustc now ICEs when there is a tab in the message:
thread 'rustc' panicked at 'assertion failed: self.text.iter().all(|r| !r.contains(&\'\\t\'))', compiler/rustc_errors/src/styled_buffer.rs:18:9
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.