Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of deprecated check_no_isolation in posix fs shims #1838

Merged
merged 3 commits into from
Jul 25, 2021

Commits on Jul 20, 2021

  1. Fix use of deprecated check_no_isolation in posix fs ops

    Update posix fs shims to use new API `reject_in_isolation`, which
    allows rejection with error code instead of always forcing abort.
    Error code chosen for each op is the most appropriate one from the
    list in corresponding syscall's manual.
    
    Updated helper APIs to not use quotes (`) around input name while
    preparing the message. This allows callers to pass multi-word string
    like -- "`read` from stdin".
    atsmtat committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    a1cabac View commit details
    Browse the repository at this point in the history
  2. Update error code for fs ops in isolation

    Change the code to either `EACCES` (if the op is performed on the
    path), or `EBADF` (if the op is performed the fd)
    
    Updated ops: `stat`, `opendir`, `ftruncate64`, and `readlink`
    
    Add a new test for fs ops in isolation.
    atsmtat committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    da68804 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. Move shim argument checks before isolation check

    This allows catching extremely incorrect arguments before rejecting
    due to isolation.
    atsmtat committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    20d0f2e View commit details
    Browse the repository at this point in the history