Clarified issues when building miri with a custom rustc #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y86-dev
commented
May 10, 2022
RalfJung
reviewed
May 10, 2022
RalfJung
reviewed
May 10, 2022
|
That makes sense, thanks! |
Co-authored-by: Ralf Jung <post@ralfj.de>
y86-dev
force-pushed
the
clarify-custom-rustc-issues
branch
from
551d529 to
b25d7b0
Compare
RalfJung
reviewed
May 10, 2022
|
@bors r+ |
|
📌 Commit 4632b2c has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across these issues (see zulip threads here and here, issue here) and would like to add this small bit to the docs. Feel free to change the wording.