Add test flag for running a test only on the host #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re dependencies to miri as CI will fail. if you want this locally, pass it to your invocation.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
RalfJung
reviewed
Jul 17, 2022
| match condition { | ||
| Condition::Bitwidth(bits) => get_pointer_width(target) == *bits, | ||
| Condition::Target(t) => target.contains(t), | ||
| Condition::OnHost => config.target.is_none(), |
There was a problem hiding this comment.
Are you sure target.is_none() will work? AFAIK we always set a target, we just usually set it equal to the default host target.
There was a problem hiding this comment.
well it did end up working in practice ^^ but I also checked and we only set the target sometimes and always compute a target by taking that or falling back to the host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.