enable clippy lints against integer casts #2422
Conversation
src/shims/mod.rs
Outdated
| @@ -1,3 +1,5 @@ | |||
| #![warn(clippy::integer_arithmetic)] | |||
There was a problem hiding this comment.
Not sure how useful this one is... none of he cases are caught, so we could just as well turn on debug asserts in release mode if we haven't already. Would be more readable than the checked math functions
There was a problem hiding this comment.
turn on debug asserts in release mode
Any suggestion for how to do that in a way that also applies to the builds produced by rustc? We cannot use cargo profiles.
Also we do have a bunch of arithmetic outside this folder (stacked borrows, data races, weak memory) that I deliberately did not enable this lint for, so there might be a performance difference. But that should be easy to benchmark.
There was a problem hiding this comment.
We can change Bootstrap's build flags for miri
There was a problem hiding this comment.
Yea I don't expect this to make a difference. It's mostly in math heavy code where this is visible in practice
There was a problem hiding this comment.
We can change Bootstrap's build flags for miri
How? RUSTFLAGS affects all dependencies so it'll rebuild everything...
I am going to move the contentious part into a separate PR.
|
@oli-obk I hope the remaining changes are uncontroversial. :) |
|
They are @bors r+ |
enable clippy lints against integer casts and arithmetic Cc #1236
RalfJung
changed the title
|
@bors retry I fixed the PR title |
|
☀️ Test successful - checks-actions |
pass clippy::integer_arithmetic in our shims `@oli-obk` [raised some concerns](#2422 (comment)) about this one. I still think it is the right call, since I don't see a good way to enable overflow checks for our official release builds. I'm open to suggestions though! Fixes #1236
Cc #1236