Backtrace performance #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2017
|
rust-lang/backtrace-rs@3d96a92 allows deferring the work now. Would need a git dependency though. |
…zily when printing
|
Done. |
oli-obk
reviewed
Aug 4, 2017
| } else { | ||
| write!(trace_text, "\n").unwrap(); | ||
| for symbol in frame.symbols() { | ||
| write!(trace_text, "{}: " , i).unwrap(); |
There was a problem hiding this comment.
the stack frame number is now reported for every symbol, instead of once for all symbols at that frame. Is that an intendend change?
There was a problem hiding this comment.
Yes. This brings the trace down to two lines per frame for the common case (one symbol per frame), making it more compact and easier to read. It also looks more like backtraces printed on panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only collect backtrace when RUST_BACKTRACE is non-empty. Also, resolve symbols lazily when printing.