-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experiment with macOS M1 runners #3433
Conversation
Hm, that doesn't seem to work -- they don't have cargo? |
Oh so the problem was the cache, interesting. No idea how a bad cache would lead to that kind of error, probably because some binaries have the wrong architecture or so? And the build was very fast, too. |
☔ The latest upstream changes (presumably #3436) made this pull request unmergeable. Please resolve the merge conflicts. |
One point I didn't realize is that this is still a tier 2 target. So there's some risk things break as rustc CI doesn't cover everything. But it's also easy to revert this PR in the future, should it become a problem. |
Judging from this GH announcement, |
I do not think the risk is very high. If aarch64 MacOS breaks, too many of us will know because we develop on it. Speed is nice. No objection to merging this. |
Yeah, makes sense. And additionally we can serve as a canary for Rust compiler stuff breaking on M1 hosts, which is a good service to the compiler team. This target is clearly going to become tier 1, so we may as well be part of slowly increasing test coverage. @bors r+ Cc @shepmaster since you seem to be tracking M1 progress. :) |
experiment with macOS M1 runners Try running our macOS CI on the new free M1 runners. This would mean that our 3 jobs run 3 different OSes and 3 different host CPU architectures. :)
looks like the M1 runners don't like it when the cache was created on x86 also reorder the lines to be more semantically grouped
@bors r+ |
☀️ Test successful - checks-actions |
To the best of my knowledge, this is in name only. Right when the M1 runners came out we enabled tests and other things that the tier 1 platforms do. It’s mostly waiting on me to do the paperwork for the promotion and I’m just waiting for a bit of stability on GitHub’s side over a medium-length time period.
I had missed that, so that might be the sign I was waiting for… |
Try running our macOS CI on the new free M1 runners. This would mean that our 3 jobs run 3 different OSes and 3 different host CPU architectures. :)