Revert "uninit intrinsic is gone" #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fa290f1. Uninit is being reinstated because it breaks some broken code.
oli-obk
reviewed
Aug 7, 2019
| @@ -522,6 +522,37 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx | |||
| this.write_scalar(res, dest)?; | |||
| } | |||
|
|
|||
| "uninit" => { | |||
| // Check fast path: we don't want to force an allocation in case the destination is a simple value, | |||
There was a problem hiding this comment.
we can be proactive and tcx.sess.warn("go update your dependencies"), even if rustc doesn't do that yet
There was a problem hiding this comment.
That will be non-actionable most of the time I think.
Also this is basically #797. We should never have warning that cannot be turned off.
|
@bors r+ |
|
📌 Commit 455531c has been approved by |
bors
added a commit
that referenced
this pull request
Aug 7, 2019
Revert "uninit intrinsic is gone" This reverts commit fa290f1. Uninit is [being reinstated](rust-lang/rust#63343) because it breaks some broken code.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fa290f1.
Uninit is being reinstated because it breaks some broken code.