Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "uninit intrinsic is gone" #895

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 7, 2019

This reverts commit fa290f1.
Uninit is being reinstated because it breaks some broken code.

This reverts commit fa290f1.
Uninit is being reinstated because it breaks some broken code.
@@ -522,6 +522,37 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
this.write_scalar(res, dest)?;
}

"uninit" => {
// Check fast path: we don't want to force an allocation in case the destination is a simple value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can be proactive and tcx.sess.warn("go update your dependencies"), even if rustc doesn't do that yet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be non-actionable most of the time I think.

Also this is basically #797. We should never have warning that cannot be turned off.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Aug 7, 2019

📌 Commit 455531c has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Aug 7, 2019

⌛ Testing commit 455531c with merge b12ebfc...

bors added a commit that referenced this pull request Aug 7, 2019
Revert "uninit intrinsic is gone"

This reverts commit fa290f1.
Uninit is [being reinstated](rust-lang/rust#63343) because it breaks some broken code.
@bors
Copy link
Contributor

bors commented Aug 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing b12ebfc to master...

@bors bors merged commit 455531c into rust-lang:master Aug 7, 2019
@RalfJung RalfJung deleted the uninit branch August 9, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants