Tidy up beneath-std, support Windows-MSVC without libc #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Unix a dependency on libc is still necessary for crt1.o. As is libunwind for any panic=unwind target (even when compiling with panic=abort, as libcore references it _Unwind_Resume from libunwind) |
|
Ah! I'll improve the comments. |
saethlin
force-pushed
the
remove-libc
branch
2 times, most recently
from
c56312b to
74df978
Compare
bjorn3
reviewed
May 19, 2024
| #![feature(panic_unwind)] | ||
| extern crate unwind; | ||
|
|
||
| // Pull in the system libc library for what crt0.o likely requires. | ||
| #[cfg(not(windows))] |
There was a problem hiding this comment.
I suspect windows-gnu still needs it, but I'm not entirely sure.
There was a problem hiding this comment.
windows-gnu includes gnu libc via the compiler. The libc crate doesn't add anything, as far as I'm aware.
saethlin
changed the title
RalfJung
reviewed
May 27, 2024
src/beneath-std.md
Outdated
| with an `extern crate libc;` declaration as shown in the examples below. | ||
| with an `extern crate libc;` declaration as shown in the examples below. Note that | ||
| windows-msvc targets do not require a libc, and correspondingly there is no `libc` | ||
| crate in their sysroot. We not need the `extern crate libc;` below, and having it |
There was a problem hiding this comment.
Suggested change
| crate in their sysroot. We not need the `extern crate libc;` below, and having it | |
| crate in their sysroot. We do not need the `extern crate libc;` below, and having it |
or something like that?
There was a problem hiding this comment.
Oops, yeah your fix is correct.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2024
Update nomicon Updates the nomicon to pull in rust-lang/nomicon#450 to fix toolstate.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2024
Update nomicon Updates the nomicon to pull in rust-lang/nomicon#450 to fix toolstate.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2024
Update nomicon Updates the nomicon to pull in rust-lang/nomicon#450 to fix toolstate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into this because my other PR breaks these examples: rust-lang/rust#124050
(also the comment about
crt0.oon these can't be right, because this was being built on Windows)