Fix build error on big endian arm/aarch64 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
added a commit
to taiki-e/setup-cross-toolchain-action
that referenced
this pull request
May 13, 2023
taiki-e
added a commit
to taiki-e/portable-atomic
that referenced
this pull request
May 13, 2023
rust-lang/portable-simd#348 ``` error[E0432]: unresolved imports `core::arch::aarch64::vqtbl1q_u8`, `core::arch::aarch64::vtbl1_u8` --> /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/../../portable-simd/crates/core_simd/src/swizzle_dyn.rs:20:46 | 20 | use core::arch::aarch64::{uint8x8_t, vqtbl1q_u8, vtbl1_u8}; | ^^^^^^^^^^ ^^^^^^^^ no `vtbl1_u8` in `core_arch::arch::aarch64` | | | no `vqtbl1q_u8` in `core_arch::arch::aarch64` | help: a similar name exists in the module | 20 | use core::arch::aarch64::{uint8x8_t, vst1q_u8, vtbl1_u8}; | ~~~~~~~~ help: a similar name exists in the module | 20 | use core::arch::aarch64::{uint8x8_t, vqtbl1q_u8, vtrn1_u8}; | ~~~~~~~~ ```
taiki-e
added a commit
to taiki-e/atomic-maybe-uninit
that referenced
this pull request
May 13, 2023
rust-lang/portable-simd#348 ``` error[E0432]: unresolved imports `core::arch::aarch64::vqtbl1q_u8`, `core::arch::aarch64::vtbl1_u8` --> /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/../../portable-simd/crates/core_simd/src/swizzle_dyn.rs:20:46 | 20 | use core::arch::aarch64::{uint8x8_t, vqtbl1q_u8, vtbl1_u8}; | ^^^^^^^^^^ ^^^^^^^^ no `vtbl1_u8` in `core_arch::arch::aarch64` | | | no `vqtbl1q_u8` in `core_arch::arch::aarch64` | help: a similar name exists in the module | 20 | use core::arch::aarch64::{uint8x8_t, vst1q_u8, vtbl1_u8}; | ~~~~~~~~ help: a similar name exists in the module | 20 | use core::arch::aarch64::{uint8x8_t, vqtbl1q_u8, vtrn1_u8}; | ~~~~~~~~ ```
|
@workingjubilee I assume this is fine? |
|
...wild. |
|
This needs to be slightly different, gimme a bit. |
|
Can this be synced into rust-lang/rust? It is breaking the build for big-endian AArch64. |
|
Signed and delivered, should be next in the pipe. Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdarch provides arm/aarch64 table lookup intrinsics instructions only on little endian targets (rust-lang/stdarch@51904cd), so core_simd currently fails to build on big endian arm/aarch64 targets.
Since rust-lang/rust#111475 (nightly-2023-05-13), builds of these targets are broken due to this bug.