Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oxford comma usage is inconsistent #664

Closed
Havvy opened this issue Aug 29, 2019 · 2 comments · Fixed by rust-lang/rust#64150
Closed

Oxford comma usage is inconsistent #664

Havvy opened this issue Aug 29, 2019 · 2 comments · Fixed by rust-lang/rust#64150

Comments

@Havvy
Copy link
Contributor

Havvy commented Aug 29, 2019

In PR #663, @hawkinsw stated that the comma usage is inconsistent.

I don't know which sites are missing commas, but they should be added where missing. @hawkinsw: Can you point out those locations?

@hawkinsw
Copy link
Contributor

hawkinsw commented Aug 29, 2019 via email

@Havvy
Copy link
Contributor Author

Havvy commented Aug 29, 2019

I'm not alarmed. If it happens, it happens. It's just nice to get it fixed when it's spotted.

@Havvy Havvy closed this as completed in af1cf6d Sep 3, 2019
Havvy added a commit that referenced this issue Sep 3, 2019
Fix #664: Review Oxford comma usage.
bors added a commit to rust-lang/rust that referenced this issue Sep 4, 2019
Update cargo, books

## cargo

8 commits in 22f7dd0495cd72ce2082d318d5a9b4dccb9c5b8c..fe0e5a48b75da2b405c8ce1ba2674e174ae11d5d
2019-08-27 16:10:51 +0000 to 2019-09-04 00:51:27 +0000
- Rename `--all` to `--workspace` (rust-lang/cargo#7241)
- Basic standard library support. (rust-lang/cargo#7216)
- Allow using 'config.toml' instead of just 'config' files. (rust-lang/cargo#7295)
- Retry on SSL Connect Error. (rust-lang/cargo#7318)
- minimal-copy `deserialize` for `InternedString` (rust-lang/cargo#7310)
- Fix typo in cargo vendor examples (rust-lang/cargo#7320)
- Fixes around multiple `[patch]` per crate (rust-lang/cargo#7303)
- Improve error messages on mkdir failure (rust-lang/cargo#7306)

## reference

7 commits in d191a0c..090c015
2019-08-15 08:42:23 +0200 to 2019-09-03 13:59:28 -0700
- Fix rust-lang/reference#664: Review Oxford comma usage. (rust-lang/reference#668)
- Fix some links. (rust-lang/reference#667)
- Remove trait object warning. (rust-lang/reference#666)
- Specify pattern types in `let` statements and `for` expressions (rust-lang/reference#663)
- Fix loop expression link. (rust-lang/reference#662)
- async-await initial reference material (rust-lang/reference#635)
- Correct errors in the reference of extern functions definitions and declarations (rust-lang/reference#652)

## rust-by-example

1 commits in 580839d90aacd537f0293697096fa8355bc4e673..e76be6b2dc84c6a992e186157efe29d625e29b94
2019-08-17 23:17:50 -0300 to 2019-09-03 07:42:26 -0300
- Change link to russian translation repository (rust-lang/rust-by-example#1245)

## embedded-book

1 commits in 432ca26686c11d396eed6a59499f93ce1bf2433c..5ca585c4a7552efb546e7681c3de0712f4ae4fdc
2019-08-09 23:20:22 +0000 to 2019-08-27 13:39:14 +0000
- Fixup book CI  (rust-embedded/book#205)
Havvy pushed a commit to Havvy/reference that referenced this issue Aug 25, 2020
This is an update to correct for the places where the Oxford
comma is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants