Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update 'dangling pointers' to new zero-sized rules #1541

Merged
merged 1 commit into from
Jul 23, 2024
Merged

update 'dangling pointers' to new zero-sized rules #1541

merged 1 commit into from
Jul 23, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 22, 2024 •
edited
Loading

This is the last step for rust-lang/rust#117945. The corresponding change in rustc has already landed (rust-lang/rust#117329).

Fixes rust-lang/rust#117945

@RalfJung RalfJung mentioned this pull request Jul 22, 2024
Closed
6 tasks
chorman0773
chorman0773 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@chorman0773 chorman0773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are correct under T-opsem FCP from ucg#472 and I have no editorial concerns.

Unless this needs a separate T-lang FCP (I seem to recall one but don't remember where, @RalfJung can you link it if one happened), I think this is good to be merged.

@chorman0773 chorman0773 added S-waiting-on-review Status: The marked PR is awaiting review from the PR author. T-opsem Team: opsem A-undefined-behavior Area: Undefined behavior and removed S-waiting-on-review Status: The marked PR is awaiting review from the PR author. labels Jul 22, 2024
@RalfJung
Copy link
Member Author

T-lang FCP happened in rust-lang/rust#117329.

@traviscross traviscross added this pull request to the merge queue Jul 23, 2024
Merged via the queue into rust-lang:master with commit f051866 Jul 23, 2024
1 check passed
@RalfJung RalfJung deleted the zero-sized branch August 2, 2024 12:37
mattheww added a commit to mattheww/nomicon that referenced this pull request Oct 15, 2024
@mattheww
Say that dereferencing a pointer to a ZST is no longer undefined
2d896fa 
The new rules were tracked in
rust-lang/rust#117945

The corresponding update to the Reference was
rust-lang/reference#1541
@mattheww mattheww mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chorman0773 chorman0773 chorman0773 approved these changes

@traviscross traviscross traviscross approved these changes

Assignees
No one assigned
Labels
A-undefined-behavior Area: Undefined behavior T-opsem Team: opsem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for allowing zero-sized memory accesses and offsets
3 participants
@RalfJung @traviscross @chorman0773