Add non_exhaustive to reference.
#609
Conversation
|
Nice! I'm looking forward to this being stabilized. The stabilization report says 1.35, but that's in about 10 days, will it maybe be in a future release? As for categorization, that's a tough one. I had originally intended that section to be just for lints, but I can't think of a better place to put it. I don't feel strongly where it goes, so unless someone else has a suggestion, I don't have a preference. |
I just wrote the next release when I was drafting that, I have no idea what release it will be. I've changed it to TBD in that document. |
davidtwco
force-pushed
the
rfc-2008-documentation
branch
from
54bfb46 to
5c0ab40
Compare
ehuss
force-pushed
the
rfc-2008-documentation
branch
from
5c0ab40 to
4852200
Compare
|
@davidtwco Just a heads up, I have rebased this PR on latest master to resolve the conflicts, so be careful updating locally. The reference has migrated to mdbook 0.3. This means that links should use the |
|
@ehuss thanks a lot for doing that, I hadn’t been checking to see if there were any conflicts. |
ehuss
added
the
S-waiting-on-stabilization
|
The stabilization PR (rust-lang/rust#64639) just went through. |
davidtwco
force-pushed
the
rfc-2008-documentation
branch
from
4852200 to
c01aff7
Compare
davidtwco
force-pushed
the
rfc-2008-documentation
branch
from
c01aff7 to
363a64a
Compare
|
LGTM; but maybe @ehuss and @petrochenkov want to take a look also. |
|
I was wondering if you would be willing to make a PR to define "inhabited" and "uninhabited" in the glossary? It is not defined anywhere, and this adds a second reference to the term, which (I think) is unclear for anyone not well versed in type theory (e.g. me). |
Signed-off-by: David Wood <david@davidtw.co>
I've added a commit which adds inhabited/uninhabited to the glossary. |
|
Thanks! ❤️ |
| @@ -65,6 +65,12 @@ For example, `2 + (3 * 4)` is an expression that returns the value 14. | |||
| An [item] that is not a member of an [implementation], such as a *free | |||
| function* or a *free const*. Contrast to an [associated item]. | |||
|
|
|||
| ### Inhabited | |||
|
|
|||
| A type is inhabited if it has constructors and therefore can be instantiated. An inhabited type is | |||
There was a problem hiding this comment.
Is your notion of "has constructors" intended to e.g. take visibility into account? That's the current definition of inhabitedness in the type system but not the abstract machine. You are describing this from the POV of the type system, right?
There was a problem hiding this comment.
Uh, yes..? I just borrowed the explanation from RFC 1216.
There was a problem hiding this comment.
I see. :) Well, this is good.
Update cargo, books. ## cargo 8 commits in 3ba5f27170db10af7a92f2b682e049397197b8fa..5da4b4d47963868d9878480197581ccbbdaece74 2019-10-22 15:05:18 +0000 to 2019-10-28 21:53:41 +0000 - Add --filter-platform to `cargo metadata`. (rust-lang/cargo#7376) - Fix `cargo fix` not showing colors. (rust-lang/cargo#7550) - Rephrase --manifest-path section (rust-lang/cargo#7409) - Add a note to discourage the use of -Zminimal-versions. (rust-lang/cargo#7549) - Fix profile override warning in a workspace. (rust-lang/cargo#7536) - Fix some tests failing on Windows nightly. (rust-lang/cargo#7534) - Show better error message for Windows abnormal termination. (rust-lang/cargo#7535) - Run `apt update` before `apt install` (rust-lang/cargo#7541) ## reference 8 commits in 5b9d2fc..4b21b64 2019-10-03 22:39:10 +0200 to 2019-10-27 22:33:11 +0100 - Document `const_constructor` feature (rust-lang/reference#677) - Add `non_exhaustive` to reference. (rust-lang/reference#609) - Re-add rust-docs component for lintcheck (rust-lang/reference#702) - group signed and unsigned integers in layout table (rust-lang/reference#700) - Fix layout table rendering (rust-lang/reference#699) - Add reference for attributes in function parameters (rust-lang/reference#657) - Update now that proc macros can expand to macro_rules. (rust-lang/reference#694) - Fix match in union example. (rust-lang/reference#684) ## book 8 commits in 9bb8b161963fcebc9d9ccd732ba26f42108016d5..28fa3d15b0bc67ea5e79eeff2198e4277fc61baf 2019-10-14 18:42:55 -0500 to 2019-10-29 07:16:09 -0500 - Update Ch19.1 on slice splitting (rust-lang/book#1999) - fixed inconsistent terminology regarding enums (rust-lang/book#2022) - Update ch15-03 code to match output. (rust-lang/book#2020) - Fixes rust-lang/book#2039 (rust-lang/book#2040) - Update ch15-03-drop.md (rust-lang/book#2049) - unit type value is also a value (rust-lang/book#2061) - Minor: remove an extraneous `.` (rust-lang/book#2059) - Clarifications and consistent use of quotation marks (rust-lang/book#1992) ## rust-by-example 4 commits in 0b111eaae36cc4b4997684be853882a59e2c7ca7..f3197ddf2abab9abdbc029def8164f4a748b0d91 2019-10-14 18:34:25 -0300 to 2019-10-29 10:17:40 -0300 - Fix typos (rust-lang/rust-by-example#1285) - Improve Cargo / Dependencies section (rust-lang/rust-by-example#1287) - Improve Cargo / Build Scripts section (rust-lang/rust-by-example#1288) - Make if_let exercise runnable (rust-lang/rust-by-example#1289)
This PR adds documentation for RFC 2008 (tracking issue rust-lang/rust#44109) to the reference.