Use variable width integer encoding for compression #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This slightly modifies the implementation in #226 to use variable width integers. This saves a touch more space with regexes with huge alternations spanning larger-than-127 instructions (typically from Unicode character classes). This also adjusts `approximate_size`, which is the actual gatekeeper behind deciding whether the DFA has filled its cache or not. The approximation is now reduced slightly to account for the space savings. The variable integer encoding used is from Protocol Buffers, documented here: https://developers.google.com/protocol-buffers/docs/encoding#varints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly modifies the implementation in #226 to use variable width
integers. This saves a touch more space with regexes with huge
alternations spanning larger-than-127 instructions (typically from Unicode
character classes).
This also adjusts
approximate_size, which is the actual gatekeeperbehind deciding whether the DFA has filled its cache or not. The approximation
is now reduced slightly to account for the space savings.
The variable integer encoding used is from Protocol Buffers, documented
here: https://developers.google.com/protocol-buffers/docs/encoding#varints