Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some debs mostly for minimal-versions #504

Merged
merged 1 commit into from
Aug 16, 2018
Merged

update some debs mostly for minimal-versions #504

merged 1 commit into from
Aug 16, 2018

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Aug 16, 2018

This bumps the minimal acceptable versions in Cargo.toml to versions that are compatible with -Z minimal-versions. This is part of the process of seeing how hard this is for crates to use in preparation for getting it stabilized for use in CI, specifically upstreaming the changes required to get criterion working with it. It is easy to use if all of your dependencies support it, but much harder if trying to impose it on them.

I am not sure I have this exactly correct. There may be more things that need to be updated for the benchmarking code to work with minimal-versions. I was not able to test with all the feachers. But I have verified that docopt can be made to work with this change to regex. So it is a step in the correct direction.

@Eh2406
Copy link
Contributor Author

Eh2406 commented Aug 16, 2018

cc @BurntSushi follow up to our discussion at Amanieu/thread_local-rs#13

lazy_static = "1"
libc = "0.2"
onig = { version = "3", optional = true }
libpcre-sys = { version = "0.2", optional = true }
memmap = "0.6"
memmap = "0.6.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this one is interesting. What requires 0.6.2 specifically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.1 requires winapi ^0.2 and <=0.2.5 do not build on rust 1.0.

Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this pretty much looks good to me! I'm surprised this was all that was needed. (Most of the deps are things I maintain, and most updates to those are driven by needs of the regex crate, so that probably helps.)

@Eh2406
Copy link
Contributor Author

Eh2406 commented Aug 16, 2018

Also to be clear this is enough for cargo check --tests to pass in the bench subfolder, the main folder, and a copy docopt pointing at this on my windows machine. Running test, and running on other machines may find more.

@BurntSushi BurntSushi merged commit 6b342fc into rust-lang:master Aug 16, 2018
@BurntSushi
Copy link
Member

Thanks!

@Eh2406
Copy link
Contributor Author

Eh2406 commented Aug 17, 2018

When in the course of human events, a new version of regex is released I can make a PR to docopt, walkdir, and handlebars. :-)

@Eh2406
Copy link
Contributor Author

Eh2406 commented Aug 24, 2018

To be a little more blunt, is there an ETA for a release that has this merged? Is there follow up that could hasen it?

@BurntSushi
Copy link
Member

I don't really do scheduled releases, but I just put regex 1.0.3 on crates.io, which has this PR.

@Eh2406
Copy link
Contributor Author

Eh2406 commented Aug 24, 2018

Thanks! Expect a bunch of downstream PR in soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants