-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update some debs mostly for minimal-versions #504
Conversation
cc @BurntSushi follow up to our discussion at Amanieu/thread_local-rs#13 |
lazy_static = "1" | ||
libc = "0.2" | ||
onig = { version = "3", optional = true } | ||
libpcre-sys = { version = "0.2", optional = true } | ||
memmap = "0.6" | ||
memmap = "0.6.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this one is interesting. What requires 0.6.2
specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6.1 requires winapi ^0.2
and <=0.2.5
do not build on rust 1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this pretty much looks good to me! I'm surprised this was all that was needed. (Most of the deps are things I maintain, and most updates to those are driven by needs of the regex crate, so that probably helps.)
Also to be clear this is enough for |
Thanks! |
When in the course of human events, a new version of |
To be a little more blunt, is there an ETA for a release that has this merged? Is there follow up that could hasen it? |
I don't really do scheduled releases, but I just put |
Thanks! Expect a bunch of downstream PR in soon. |
This bumps the minimal acceptable versions in Cargo.toml to versions that are compatible with
-Z minimal-versions
. This is part of the process of seeing how hard this is for crates to use in preparation for getting it stabilized for use in CI, specifically upstreaming the changes required to get criterion working with it. It is easy to use if all of your dependencies support it, but much harder if trying to impose it on them.I am not sure I have this exactly correct. There may be more things that need to be updated for the benchmarking code to work with minimal-versions. I was not able to test with all the feachers. But I have verified that
docopt
can be made to work with this change toregex
. So it is a step in the correct direction.