Clarify definition of "input positions" in lifetime elision RFC. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly note that lifetimes from the `impl` (and `trait`/`struct`) are not considered "input positions" for the purposes of expanded `fn` definitions. Added a collection of examples illustrating this. Drive-by: Addressed a review comment from @chris-morgan [here](rust-lang#141 (comment)).
|
r? @aturon |
| result types. So `fn foo(s: &str) -> (&str, &str)` has elided one lifetime in | ||
| input position and two lifetimes in output position. | ||
| Note that the input positions of a `fn` method definition do not | ||
| include the lifetimes that occur in the method's `impl` header | ||
| `impl` (nor lifetimes that occur in the trait header, for a default |
There was a problem hiding this comment.
arg, typo here, "impl header impl" probably should be just "impl header". (I was originally going to spell out which components of the impl header I am referring to here, but then decided mid-stream not to bother.)
|
This looks good to me! Thanks for adding these clarifications. |
|
(I don't have the rights to merge, however.) |
Also fixed mistake from previous commit (I moved an example up a few lines but forgot to delete the original).
alexcrichton
added a commit
that referenced
this pull request
Jul 15, 2014
Clarify definition of "input positions" in lifetime elision RFC.
Centril
added
A-typesystem
wycats
pushed a commit
to wycats/rust-rfcs
that referenced
this pull request
Mar 5, 2019
Added the missing }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly note that lifetimes from the
impl(andtrait/struct) are not considered "input positions" for the purposes of expandedfndefinitions.Added a collection of examples illustrating this.
Drive-by: Addressed a review comment from @chris-morgan here.
Fix #165.