Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new RFCs to list #1714

Closed
wants to merge 1 commit into from
Closed

Conversation

pthariensflame
Copy link
Contributor

@pthariensflame pthariensflame commented Aug 13, 2016

Continuation of #1706.

@durka wanted some kind of automated mechanism for doing this; what would be the best way to accomplish that?

@strega-nil
Copy link

Perhaps as part of merging a new RFC, add it to the README?

@durka
Copy link
Contributor

durka commented Aug 13, 2016

@ubsan they're not merged during discussion, though.

On Aug 13, 2016 14:32, "Nicole Mazzuca" notifications@github.com wrote:

Perhaps as part of merging a new RFC, add it to the README?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1714 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC3n5xGYmdt1Gcb90YaqVGEYuQg0Eu6ks5qfg3VgaJpZM4Jjuv-
.

@Ericson2314
Copy link
Contributor

I thought "active" meant accepted but not yet implemented?

@pthariensflame
Copy link
Contributor Author

pthariensflame commented Aug 13, 2016

@Ericson2314 It does mean that.

@Ericson2314
Copy link
Contributor

Ok good. Then adding to the list on merge as @ubsan suggests will indeed work.

@nrc
Copy link
Member

nrc commented Aug 14, 2016

Actually, it would be nice to have a bit more tooling support for merging an RFC - it should be a one-click thing, but it is actually a pain - you often have to rename the file, check the 'header' details are correct. Add the PR link, file a tracking issue, add that link, then add the merged RFC to the list in README. This should all be doable by a bot. It would be a nice little project to write - would need to know about Git and GitHub, etc. If anyone wants to have a go at this I'd be happy to help out with advice on the various APIs, etc. And we have accounts for bots that we could use (rust-highfive, for example) which have the necessary privs.

@pthariensflame
Copy link
Contributor Author

@nrc I would be more than happy to write a bot that does this! I just need to ramp up into understanding the GitHub APIs. :)

@nrc
Copy link
Member

nrc commented Aug 15, 2016

@pthariensflame let me know if you have any questions (probably irc is best, I'm nrc there too) - the GH APIs are not too bad to learn, once you get your head around the basic architecture. Here is an example of one of our bots - it handles triage on the main Rust repo, it is node.js, but should be pretty easy to see what the API calls are doing for a Rust bot.

@pthariensflame
Copy link
Contributor Author

The repository which will eventually contain the bot is here:
https://github.com/chirex-machinens/RFC-stuff

@pthariensflame
Copy link
Contributor Author

Updated in light of #1679 being merged.

@pthariensflame
Copy link
Contributor Author

Updated again in light of #1681 being merged.

@alexcrichton
Copy link
Member

Thanks for the PR @pthariensflame! We discussed this briefly in the core team meeting yesterday and the conclusion was that we're going to remove this section from the README which, as I'm sure you can tell, is updated in a very sporadic, if ever, fashion.

Perhaps if we get more tooling we can re-add this section, but for now I'm gonna send a commit to remove it and close this for now.

@pthariensflame
Copy link
Contributor Author

That's fine! I feel like we can come up with a better interface to this information anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants