Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling methods on generic parameters of const fns #2632

Closed
wants to merge 37 commits into from
Closed

Calling methods on generic parameters of const fns #2632

wants to merge 37 commits into from

Commits on Oct 5, 2018

  1. Const generic const fn bounds

    @oli-obk
    oli-obk committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    bb42eea View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Update to rust-rfcs/const-eval repo version

    @oli-obk
    oli-obk committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    cb3f9f0 View commit details
    Browse the repository at this point in the history

  2. Elaborate on drawbacks

    @oli-obk
    oli-obk committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    9d22849 View commit details
    Browse the repository at this point in the history

  3. Make an example actually compile

    @oli-obk
    oli-obk committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    ea6f4cc View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Drop the correct type 

    Co-Authored-By: oli-obk <github35764891676564198441@oli-obk.de>
    @fbstj @oli-obk
    fbstj and oli-obk committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    66d8354 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. Nit

    @oli-obk
    oli-obk committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    c0924f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2019

  1. Address const Drop issues

    @oli-obk
    oli-obk committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    a9f09d2 View commit details
    Browse the repository at this point in the history

  2. Talk about const A + B operator precedence

    @oli-obk
    oli-obk committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    bff5483 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-Authored-By: oli-obk <github35764891676564198441@oli-obk.de>
    @Centril @oli-obk
    Centril and oli-obk committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    2301e8c View commit details
    Browse the repository at this point in the history

  4. Add missing word

    @oli-obk
    oli-obk committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    59036c2 View commit details
    Browse the repository at this point in the history

  5. Arrays and tuples are const drop if all their fields are

    @oli-obk
    oli-obk committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    48936b2 View commit details
    Browse the repository at this point in the history

  6. Clear up const Drop vs const Drop fields

    @oli-obk
    oli-obk committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    5c4d543 View commit details
    Browse the repository at this point in the history

  7. Comma nits 

    Co-Authored-By: oli-obk <github35764891676564198441@oli-obk.de>
    @Centril @oli-obk
    Centril and oli-obk committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    a4d849a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2019

  1. Remove mentions of T: const Drop

    @oli-obk
    oli-obk committed Feb 17, 2019
    Configuration menu
    Copy the full SHA
    63d7d72 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2019

  1. Summarize the Drop discussion on the RFC PR

    @oli-obk
    oli-obk committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    3c6e1d6 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. Start with a simpler example

    @oli-obk
    oli-obk committed Mar 12, 2019
    Configuration menu
    Copy the full SHA
    0694122 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Document drop glue trait

    @oli-obk
    oli-obk committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    0de567d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Remove any mention of Cell

    @oli-obk
    oli-obk committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    e03416e View commit details
    Browse the repository at this point in the history

  2. Add open syntax questions

    @oli-obk
    oli-obk committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    e19da15 View commit details
    Browse the repository at this point in the history

  3. Remove unactionable open question

    @oli-obk
    oli-obk committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    52fcff0 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. Clarify all uses of "currently"

    @oli-obk
    oli-obk committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    ab138de View commit details
    Browse the repository at this point in the history

  2. ?const Drop is useless

    @oli-obk
    oli-obk committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    0929ed9 View commit details
    Browse the repository at this point in the history

  3. ConstDrop is not similar to Copy

    @oli-obk
    oli-obk committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    1b5feef View commit details
    Browse the repository at this point in the history

  4. Maybe we don't need ConstDrop after all

    @oli-obk
    oli-obk committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    93de852 View commit details
    Browse the repository at this point in the history

  5. correct indentation

    @oli-obk
    oli-obk committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    8fa3c93 View commit details
    Browse the repository at this point in the history

  6. Remove ConstDrop in favour of extending const Drop

    @oli-obk
    oli-obk committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    495cef6 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Explain the issues with inferring const Drop

    @oli-obk
    oli-obk committed Apr 11, 2019
    1 Configuration menu
    Copy the full SHA
    6de0a77 View commit details
    Browse the repository at this point in the history

  2. Remove invalid section reference

    @oli-obk
    oli-obk committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    2637a08 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. Mirror some examples in effect syntax

    @oli-obk
    oli-obk committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    cc1e8bb View commit details
    Browse the repository at this point in the history

  2. Crosslink between related sections in the RFC

    @oli-obk
    oli-obk committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    dabdff5 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. Motivate ?const Trait

    @oli-obk
    oli-obk committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    68721d8 View commit details
    Browse the repository at this point in the history

  2. Specifically mention that ?const is experimental

    @oli-obk
    oli-obk committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    7e349a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2019

  1. Update 0000-const-generic-const-fn-bounds.md

    @oli-obk
    oli-obk committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    fcf00a2 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Update text/0000-const-generic-const-fn-bounds.md 

    Co-authored-by: Christopher Durham <cad97@cad97.com>
    @oli-obk @CAD97
    oli-obk and CAD97 committed May 6, 2020
    Configuration menu
    Copy the full SHA
    2600c3a View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. some editing to better reflect my concern

    @RalfJung
    RalfJung committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    fe03f3a View commit details
    Browse the repository at this point in the history

  2. more edit and reorder fn/dyn

    @RalfJung
    RalfJung committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    7ac09e8 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from RalfJung/const_generic_const_fn_bounds

    @oli-obk
    oli-obk committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    daac3ce View commit details
    Browse the repository at this point in the history