RFC: Add a process_group method to UNIX CommandExt
#3228
Conversation
krallin
changed the title
process_group method to UNIX CommandExtprocess_group method to UNIX CommandExt
krallin
force-pushed
the
process-process_group
branch
from
a152f8a
to
1a4a930
Compare
krallin
force-pushed
the
process-process_group
branch
from
1a4a930
to
695d47e
Compare
ehuss
added
the
T-libs-api
|
For reference, this is what the implementation could look like: |
|
Seems entirely reasonable to me. Strictly speaking, this is the kind of change we don't typically require a full RFC for, but since you have one... @rfcbot merge |
|
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
@krallin In parallel with the RFC, if you take the branch you linked to, file a tracking issue, and update your branch to use that tracking issue, I'd be happy to r+ it as a PR. |
|
@joshtriplett Thanks for reviewing! Indeed, I wasn't sure if I needed a RFC, it seemed like public API changes would always require one! I opened the tacking issue: rust-lang/rust#93857 And submitted the PR: rust-lang/rust#93858 |
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
…shtriplett Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
…shtriplett Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
|
Missing rendered url. |
rfcbot
added
the
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
removed
the
proposed-final-comment-period
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
…olnay Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
…olnay Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
…olnay Add a `process_group` method to UNIX `CommandExt` - Tracking issue: rust-lang#93857 - RFC: rust-lang/rfcs#3228 Add a `process_group` method to `std::os::unix::process::CommandExt` that allows setting the process group id (i.e. calling `setpgid`) in the child, thus enabling users to set process groups while leveraging the `posix_spawn` fast path.
Add a
process_groupmethod tostd::os::unix::process::CommandExtthatallows setting the process group id (i.e. calling
setpgid) in the child, thusenabling users to set process groups while leveraging the
posix_spawnfastpath.
Rendered