Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Templating CARGO_TARGET_DIR to make it the parent of all target directories #3371

Closed
wants to merge 67 commits into from
Closed

RFC: Templating CARGO_TARGET_DIR to make it the parent of all target directories #3371

wants to merge 67 commits into from

Commits on Jan 12, 2023

  1. rfc: CARGO_TARGET_DIRECTORIES: initial proposal version

    @poliorcetics
    poliorcetics committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4faf132 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. chore: use PR number in file name

    @poliorcetics
    poliorcetics committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    0a0df4c View commit details
    Browse the repository at this point in the history

  2. feat: Improve "alternatives" and "prior art" sections following review.

    @poliorcetics
    poliorcetics committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    0b53b39 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. nit: clarify some lines

    @poliorcetics
    poliorcetics committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    6082243 View commit details
    Browse the repository at this point in the history

  2. fix: improve bazel section, fix missing link

    @poliorcetics
    poliorcetics committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    ed55d46 View commit details
    Browse the repository at this point in the history

  3. feat: use hashing in the naming scheme

    @poliorcetics
    poliorcetics committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    5f869bc View commit details
    Browse the repository at this point in the history

  4. feat: discuss remapping

    @poliorcetics
    poliorcetics committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    aafee1c View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. nit: missing <hash>

    @poliorcetics
    poliorcetics committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    4c89e34 View commit details
    Browse the repository at this point in the history

  2. fix: decisively declare non-stability of naming scheme

    @poliorcetics
    poliorcetics committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    a3b8c7c View commit details
    Browse the repository at this point in the history

  3. feat: talk about symlinks resolving

    @poliorcetics
    poliorcetics committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    4ea813c View commit details
    Browse the repository at this point in the history

  4. nit: clarify cargo clean behaviour explanation

    @poliorcetics
    poliorcetics committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    a8fae16 View commit details
    Browse the repository at this point in the history

  5. fix: link to targo and add backlinks subsection

    @poliorcetics
    poliorcetics committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    f2a8448 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2023

  1. Expand on using CARGO_TARGET_DIRECTORIES as the default

    @poliorcetics
    poliorcetics committed May 28, 2023
    Configuration menu
    Copy the full SHA
    bd8b690 View commit details
    Browse the repository at this point in the history

  2. Clarify we hash on the symlink-resolved form of the path

    @poliorcetics
    poliorcetics committed May 28, 2023
    Configuration menu
    Copy the full SHA
    7a1ee20 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. rename CARGO_TARGET_DIRECTORIES to CARGO_TARGET_BASE_DIR

    @poliorcetics
    poliorcetics committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    35e99f6 View commit details
    Browse the repository at this point in the history

  2. rename file to follow feature renaming

    @poliorcetics
    poliorcetics committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    c2300bb View commit details
    Browse the repository at this point in the history

  3. question: how do we handle possibly thousand of directories in the sa… 

    …me parent
    @poliorcetics
    poliorcetics committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4a6cb64 View commit details
    Browse the repository at this point in the history

  4. clarify situation for third party cargo tools

    @poliorcetics
    poliorcetics committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7ac2013 View commit details
    Browse the repository at this point in the history

  5. typo: dire -> directory

    @poliorcetics
    poliorcetics committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    b1aa45e View commit details
    Browse the repository at this point in the history

  6. clarify CARGO_HOME as target base dir

    @poliorcetics
    poliorcetics committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    3676816 View commit details
    Browse the repository at this point in the history

  7. don't use line breaks, they make following changes harder since they … 

    …have to be maintained manually
    @poliorcetics
    poliorcetics committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    0520ea8 View commit details
    Browse the repository at this point in the history

  8. expand upon targo caching scheme

    @poliorcetics
    poliorcetics committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    f604f0a View commit details
    Browse the repository at this point in the history

  9. propose alternate naming scheme to simply scaling in unresolved quest… 

    …ions
    @poliorcetics
    poliorcetics committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    d7830f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. underspecify naming scheme and use manifest instead of workspace dir,… 

    … in preparation for cargo-script
    @poliorcetics
    poliorcetics committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    e79c752 View commit details
    Browse the repository at this point in the history

  2. Clarify one advantage 

    Co-authored-by: Rain <rain@sunshowers.io>
    @poliorcetics @sunshowers
    poliorcetics and sunshowers authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a245144 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Add drawback about windows path length limits

    @poliorcetics
    poliorcetics committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    a7af623 View commit details
    Browse the repository at this point in the history

  2. keeping local target dir even if the default changes

    @poliorcetics
    poliorcetics committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    001f27f View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Typo fix 

    Co-authored-by: Jacob Lifshay <programmerjake@gmail.com>
    @poliorcetics @programmerjake
    poliorcetics and programmerjake authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e3fda64 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. introduce backlinks and expand on them

    @poliorcetics
    poliorcetics committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    5d33e78 View commit details
    Browse the repository at this point in the history

  2. mention garbage collection in future possibilities

    @poliorcetics
    poliorcetics committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    46f4b80 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. nit: fix unclear text

    @poliorcetics
    poliorcetics committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    10e2d19 View commit details
    Browse the repository at this point in the history

  2. clarify text about setting CARGO_TARGET_DIR for cargo calls

    @poliorcetics
    poliorcetics committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    c386c97 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. clarify backlinks and forward links, I misunderstood them at first

    @poliorcetics
    poliorcetics committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    a519e7c View commit details
    Browse the repository at this point in the history

  2. cleanup of RFC text to make less use of 'I', 'we', add a link to targ… 

    …o and clarify in response to Ehuss' question
    @poliorcetics
    poliorcetics committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    50251e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. feat: move to templating CARGO_TARGET_DIR instead of a new config `… 

    …CARGO_TARGET_BASE_DIR`
    @poliorcetics
    poliorcetics committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    0e5d30e View commit details
    Browse the repository at this point in the history

  2. fix: add transition period notice

    @poliorcetics
    poliorcetics committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    9e119ef View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. rename file to follow feature rename

    @poliorcetics
    poliorcetics committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    d4fd860 View commit details
    Browse the repository at this point in the history

  2. nit: missed BASE_

    @poliorcetics
    poliorcetics committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    9945d9a View commit details
    Browse the repository at this point in the history

  3. point to the discussion on garbage collection

    @poliorcetics
    poliorcetics committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    d222d65 View commit details
    Browse the repository at this point in the history

  4. expand on exposing template metadata

    @poliorcetics
    poliorcetics committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    aea0adb View commit details
    Browse the repository at this point in the history

  5. caching in cargo home discussion

    @poliorcetics
    poliorcetics committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    376c306 View commit details
    Browse the repository at this point in the history

  6. move forward links sections to Unresolved questions

    @poliorcetics
    poliorcetics committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    befae7d View commit details
    Browse the repository at this point in the history

  7. specify link-target-dir

    @poliorcetics
    poliorcetics committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    07f899b View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Explain the advantages of hashes over copied folder tree structure

    @poliorcetics
    poliorcetics committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fac2d9c View commit details
    Browse the repository at this point in the history

  2. fix: put section back where it belong, it was one level too deep

    @poliorcetics
    poliorcetics committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    23ae70a View commit details
    Browse the repository at this point in the history

  3. drawback: brace expansion

    @poliorcetics
    poliorcetics committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    025b8ef View commit details
    Browse the repository at this point in the history

  4. future possibilities: remove section about metadata since there is no… 

    … clear possible use
    @poliorcetics
    poliorcetics committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8d1ddc2 View commit details
    Browse the repository at this point in the history

  5. link to issue 1734 for other possible templates discussions

    @poliorcetics
    poliorcetics committed Feb 19, 2024
    2 Configuration menu
    Copy the full SHA
    b81b3ed View commit details
    Browse the repository at this point in the history

  6. fix link to garbage collection issue

    @poliorcetics
    poliorcetics committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2ae536e View commit details
    Browse the repository at this point in the history

  7. delete section about providing backlinks

    @poliorcetics
    poliorcetics committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    11ab0e3 View commit details
    Browse the repository at this point in the history

  8. expand a lot on forward links, adding them to the RFC and not just as… 

    … an unresolved question
    @poliorcetics
    poliorcetics committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6540d11 View commit details
    Browse the repository at this point in the history

  9. default with template fix

    @poliorcetics
    poliorcetics committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1195538 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. nit: simplify section title for template variables

    @poliorcetics
    poliorcetics committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    3cead0d View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. nit: no double negatives

    @poliorcetics
    poliorcetics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    3a6fa3e View commit details
    Browse the repository at this point in the history

  2. nit: clarify the point about path length as an argument for hashes

    @poliorcetics
    poliorcetics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    645d9c4 View commit details
    Browse the repository at this point in the history

  3. clarify summary by being more explicit (and fix a typo)

    @poliorcetics
    poliorcetics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    05b96f8 View commit details
    Browse the repository at this point in the history

  4. nit: fix a forgotten 'target-base-dir' remnant

    @poliorcetics
    poliorcetics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    226f9ec View commit details
    Browse the repository at this point in the history

  5. feat: only one new option, not two, handle concurrent builds predictably

    @poliorcetics
    poliorcetics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    2802659 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. feat: clarify template-as-default section in future possibilites

    @poliorcetics
    poliorcetics committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    d879751 View commit details
    Browse the repository at this point in the history

  2. nit: remove nonsense line

    @poliorcetics
    poliorcetics committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    0f71cf5 View commit details
    Browse the repository at this point in the history

  3. nit: move transition period section

    @poliorcetics
    poliorcetics committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    927226d View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. feat: expand on transition period

    @poliorcetics
    poliorcetics committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    a821d25 View commit details
    Browse the repository at this point in the history

  2. feat: mention key for a future default cargo default target directory

    @poliorcetics
    poliorcetics committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    5dcfb29 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. chore: move Transition Period section to reference level explanation

    @poliorcetics
    poliorcetics committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    774e328 View commit details
    Browse the repository at this point in the history

  2. feat: clarify the 'Naming' section 

    Thanks epage for the suggestions.
    @poliorcetics
    poliorcetics committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    81bac72 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. nit: forgotten 'an'

    @poliorcetics
    poliorcetics committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    0a38c07 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. feat: add future possibilities for templating other configs

    @poliorcetics
    poliorcetics committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d549cb1 View commit details
    Browse the repository at this point in the history