-
Notifications
You must be signed in to change notification settings - Fork 256
Compiler panics on latest RLS when compiling crates that depend on bitflags
1.0.5
#1449
Comments
I haven't diagnosed which crate triggers another of these, but I'm also getting an error when compiling diesel:
I tried downgrading to an older Rust release (1.33.0) and it did not fix this issue. |
Same thing with
|
Same with
|
I also noticed the same issue when trying to use the
|
I checked the common dependencies of all affected crates. It seems that the |
That seems to have worked for me too. |
Nice one guys Now we need to figure out why rls can't handle this dependency when cargo can. |
nix
cratebitflags
1.0.5
It'd be interesting to see what the changes between 1.0.4 and 1.0.5 are. Semver says "minor". |
|
Copying my stacktrace from #1450 for convenience:
|
1.0.5 causes rls to crash. See rust-lang/rls#1449.
Oh dear... I’d forgotten we had an RLS issue caused by the changes in The author pointed out the crash initially. Pinning |
Same issue here while compiling |
I got the issue when using shrinkwraprs as a dependency. None of its versions worked. I had to actually strip it out. |
@KodrAus consider yanking 1.0.5 until rust-lang/rust#59134 is fixed to reduce the impact of the bug - you can probably just republish it as 1.0.6 after this is sorted out |
@jonas-schievink Well, that bug was logged a few months ago and doesn't appear to have made any forward progress in that time. Do we know what a fix in RLS would look like? Having RLS simply not work for such a pervasive dependency is unfortunate though, so I'll yank EDIT: Actually, that comment about not making forward progress is a bit unfair. It looks like you are exploring a fix. |
Alrighty, |
Thanks everyone for investigating and posting a workaround! The fix for the current nightly is pending at rust-lang/rust#60649 (which hopefully will be backported to beta, in which case it will be available in Rust 1.35) |
save-analysis: Fix ICE when processing associated constant Closes #59134 Closes rust-lang/rls#1449 Thanks @swgillespie for helping tracking this down and fixing it! r? @eddyb
I'm trying to develop a crate which ends up using
nix
as a dependency.I'm getting the following error through RLS since I've updated to the latest stable:
(stable-x86_64-unknown-linux-gnu unchanged - rustc 1.34.1 (fc50f328b 2019-04-24), ArchLinux 5.0.10-arch1-1-ARCH)
Using
"rust-client.logToFile": true,
to get the log, I get this additional information:I'm unsure whether this is an RLS or Rust bug, but this error does not happen when compiling through
cargo check
,cargo build
,cargo build --release
,cargo doc
, etc, only through RLS, and I may not be able to give proper information in a rustc issue as to what the precise flags that cause this are.The following minimal project triggers the bug when opening VSCode with the RLS extension installed :
Cargo.toml
:src/main.rs
:The text was updated successfully, but these errors were encountered: