This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Bump cargo version #1767
Merged
Bump cargo version #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rust-lang/cargo@7248f4b, `cargo::core::resolver::resolve::Resolve::extern_crate_name` was renamed to `extern_crate_name_and_dep_name` and started to return both extern crate and dep name. RLS only needs extern crate name at this moment.
|
@ehuss |
|
Sorry for the lag, looks good. Thanks for the ping and the PR! |
This was referenced Apr 4, 2022
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 9, 2022
…lbini Update RLS This PR updates RLS to include the following PRs: * rust-lang/rls#1766 * rust-lang/rls#1767 * rust-lang/rls#1771 * rust-lang/rls#1772 It also updates racer to fix RLS compilation with the parallel compiler enabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust-lang/cargo@7248f4b,
cargo::core::resolver::resolve::Resolve::extern_crate_namewas renamedto
extern_crate_name_and_dep_nameand started to return both externcrate and dep name. RLS only needs extern crate name at this moment.
Not sure if there is any crate using rls as a libbrary directly.
I assume no, so I change the type of the pub field
Dep.crate_name.If this is not appropriate, I can alternatively keep it as
String.