This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Add clippy as an optional feature #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
commented
Feb 3, 2018
src/build/rustc.rs
Outdated
| @@ -70,7 +73,11 @@ pub fn rustc( | |||
|
|
|||
| let buf = Arc::new(Mutex::new(vec![])); | |||
| let err_buf = buf.clone(); | |||
| let args = args.to_owned(); | |||
| let args: Vec<_> = if cfg!(feature = "clippy") { | |||
| args.iter().map(|s| s.to_owned()).chain(Some("-Aclippy".to_owned())).collect() | |||
There was a problem hiding this comment.
Slight hackery. Clippy automatically turns certain lints to warn by default. This undoes that. You can reenable them in the code though.
|
Cool, looks good! If you could rebase I'll merge asap. |
|
Oliver, I have a hacked local version of this, but I tust you and will now compile this. Let's see if I can manage to demo it this afternoon or if everything explodes! :) |
|
rebased |
worst case you'll need to remove the hack with the -Aclippy, but I think it should just work |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @killercup
5 internet points for whomever who merges it before 14:00 UTC Sunday