Skip to content

Commit

Permalink
Bump vscode-languageclient
Browse files Browse the repository at this point in the history
  • Loading branch information
lnicola committed Jul 9, 2022
1 parent 666343b commit 03a62c1
Show file tree
Hide file tree
Showing 4 changed files with 38 additions and 35 deletions.
64 changes: 32 additions & 32 deletions editors/code/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion editors/code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"dependencies": {
"d3": "^7.3.0",
"d3-graphviz": "^4.1.0",
"vscode-languageclient": "8.0.0-next.14"
"vscode-languageclient": "^8.0.1"
},
"devDependencies": {
"@types/node": "~14.17.5",
Expand Down
4 changes: 4 additions & 0 deletions editors/code/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,10 @@ export async function createClient(
}

class ExperimentalFeatures implements lc.StaticFeature {
getState(): lc.FeatureState {
return { kind: "static" };
}

fillClientCapabilities(capabilities: lc.ClientCapabilities): void {
const caps: any = capabilities.experimental ?? {};
caps.snippetTextEdit = true;
Expand Down
3 changes: 1 addition & 2 deletions editors/code/src/ctx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ export class Ctx {

const res = new Ctx(config, extCtx, client, serverPath, statusBar);

res.pushCleanup(client.start());
await client.onReady();

This comment has been minimized.

Copy link
@Veykril

Veykril Jul 22, 2022

Member

I assume this is the problem with #12836

This comment has been minimized.

Copy link
@Veykril

Veykril Jul 22, 2022

Member

Actually probably not, we should be cleaning it up properly still (we do call stop)

await client.start();
client.onNotification(ra.serverStatus, (params) => res.setServerStatus(params));
return res;
}
Expand Down

0 comments on commit 03a62c1

Please sign in to comment.