Incorrect replace return <expr>; with <expr> diagnostic

[Veykril]

rust-analyzer/crates/mbe/src/expander/matcher.rs

Line 184 in 1e6cef9

return BindingsIdx(idx, nidx);

The transformation here is is not valid so the diagnostic shouldnt' trigger

[davidsemakula]

@rustbot claim

[matze]

Is this really fixed? It shows up in the macro invocation in this MWE with 0.3.1860-standalone (Update: and 0.3.1868-standalone):

#[tokio::main]
async fn main() {}

[mike-lloyd03]

I'm seeing it as well using anyhow on 5346002 2024-02-25.

if something {
    Ok(value)
} else {
    bail!("Something broke")
}

[xpe]

I'm also seeing this warning when using Zed Preview 0.124.6 which is using:

rust-analyzer 0.3.1860-standalone (5346002d0 2024-02-25)

[PastelStoic]

I get the same error, even with an empty main.

[ghost]

I get the same error on my unpublished codebase where all the possible cases of this hint have been solved and only the required returns are present.

[Cugatay]

Hey, I still get the same error. Is there any update?

[abbygriffiths]

Issue does not seem to be fixed. Seeing the issue on Neovim on the latest stable build of Rust + rust_analyzer

[igor-f-nevski]

Same here. Issue just appeared for me actually. Tried on Zed and Helix, not that it should matter.

[flodiebold]

The commit marking the diagnostic as experimental will be included in today's release.

[matze]

Indeed, it's fixed. Thanks whoever contributed that 🍻

[ahmedriza]

Still getting this with rust-analyzer version:

rust-analyzer 0.0.0 (ffbc5ad993 2024-07-11)

rustc version:

rustc 1.79.0 (129f3b996 2024-06-10)

The code is just an empty main: