Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-analyzer analysis hangs up while mir building/evaluating in the standard library #18326

Closed
Veykril opened this issue Oct 18, 2024 · 6 comments · Fixed by #18328
Closed

rust-analyzer analysis hangs up while mir building/evaluating in the standard library #18326

Veykril opened this issue Oct 18, 2024 · 6 comments · Fixed by #18328
Assignees
@Veykril
Labels
Broken Window Bugs / technical debt to be addressed immediately

Comments

@Veykril
Copy link
Member

Veykril commented Oct 18, 2024 •
edited
Loading

Since the newest stable release our CI hangs up on the linux runner. https://github.com/rust-lang/rust-analyzer/actions/runs/11393691962/job/31702512392?pr=18305
@Veykril Veykril added the Broken Window Bugs / technical debt to be addressed immediately label Oct 18, 2024
@ChayimFriedman2
Copy link
Contributor

What is the latest good PR?

@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

The problem is not a change on our side, 1.82 released yesterday and so we now run analysis stats against that, something in the standard library is causing us problems now (though its a bug in our code nevertheless, we shouldn't hang here). Also note this is not linux specific, its just that we run analysis-stats on linux only in PR CI

@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

(so with newest stable release I was referring to rust release, not rust-analyzer)

@ChayimFriedman2
Copy link
Contributor

ChayimFriedman2 commented Oct 18, 2024 •
edited
Loading

I've been running analysis stats . today with 1.82 on Windows with no problem (but not on linux, will check). Edit: Checked on Linux, it goes fine.

Edit: Oh but I was running with release, I see CI is running debug. Are you sure it's stuck and not just slower?

@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

You need to run it against the standard library, ci runs target//debug/rust-analyzer analysis-stats --with-deps $(rustc --print sysroot)/lib/rustlib/src/rust/library/std

@Veykril Veykril self-assigned this Oct 18, 2024
@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2024

Right, this is the first release where the sysroot has a proper cargo workspace. EIther way we seem to not have miri set properly here, causing us to run a test gated behind not(miri)

@Veykril Veykril mentioned this issue Oct 18, 2024
Merged
bors added a commit that referenced this issue Oct 18, 2024
@bors
Auto merge of #18328 - Veykril:veykril/push-zrzmmyqzqwyr, r=
e416842 
fix: Fix CI running analysis-stats incorrectly against the standard libraries

Fixes #18326
bors added a commit that referenced this issue Oct 18, 2024
@bors
Auto merge of #18328 - Veykril:veykril/push-zrzmmyqzqwyr, r=Veykril
efb7ea4 
fix: Fix CI running analysis-stats incorrectly against the standard libraries

Fixes #18326
@bors bors closed this as completed in 6703d7a Oct 18, 2024
lnicola pushed a commit to lnicola/rust that referenced this issue Oct 22, 2024
@bors
Auto merge of rust-lang#18328 - Veykril:veykril/push-zrzmmyqzqwyr, r=…
6b919c4 
…Veykril

fix: Fix CI running analysis-stats incorrectly against the standard libraries

Fixes rust-lang/rust-analyzer#18326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Veykril Veykril

Labels
Broken Window Bugs / technical debt to be addressed immediately
Projects
None yet
Milestone
No milestone
2 participants
@Veykril @ChayimFriedman2