internal: don't shut up the compiler when it says the code's buggy #10080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping state-modifying functions into a `catch_unwind` is wrong -- to do retry after failure, you need to have transactional semantics!
|
Canceled. |
|
bors r+ |
matklad
commented
Aug 30, 2021
| /// (`on` method). | ||
| /// | ||
| /// Some read-only requests are latency sensitive, and are immediately handled | ||
| /// on the main loop thread (`on_sync`). These are typically typing-related |
There was a problem hiding this comment.
@Veykril [`RequestDispatcher::on_sync`] doesn't work for me. Is it our bug, or is this just isn't supported by rustdoc?
There was a problem hiding this comment.
Ye I'm pretty sure that should work with rustdoc. Odd that we don't resolve this 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors r+
🤖