Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move arm cond to match guard #1281

Merged
merged 3 commits into from
May 22, 2019
Merged

Move arm cond to match guard #1281

merged 3 commits into from
May 22, 2019

Conversation

unrealhoang
Copy link
Contributor

I did split the rename to another commit, yet Github UI still show entirely new file change. Please review using commits.

@unrealhoang unrealhoang force-pushed the move_arm_cond_to_match_guard branch 2 times, most recently from a3fa698 to 6151f0e Compare May 16, 2019 05:14
matklad
matklad reviewed May 20, 2019
View reviewed changes
crates/ra_assists/src/move_guard_to_arm_body_and_back.rs Outdated Show resolved Hide resolved
crates/ra_assists/src/lib.rs Outdated Show resolved Hide resolved
crates/ra_assists/src/move_guard_to_arm_body_and_back.rs Outdated Show resolved Hide resolved
crates/ra_assists/src/move_guard_to_arm_body_and_back.rs Outdated Show resolved Hide resolved
@matklad
Copy link
Member

matklad commented May 20, 2019

@unrealhoang sorry for a long delay here: it's been a very busy week for me :(

@unrealhoang unrealhoang force-pushed the move_arm_cond_to_match_guard branch 3 times, most recently from 8285e19 to 90392dd Compare May 21, 2019 13:30
@unrealhoang unrealhoang force-pushed the move_arm_cond_to_match_guard branch from 90392dd to 079ed60 Compare May 21, 2019 14:32
@matklad
Copy link
Member

matklad commented May 22, 2019

bors r+

Thanks!

bors bot added a commit that referenced this pull request May 22, 2019
@bors @unrealhoang
Merge #1281
67d5927 
1281: Move arm cond to match guard r=matklad a=unrealhoang

I did split the rename to another commit, yet Github UI still show entirely new file change. Please review using commits.

Co-authored-by: Unreal Hoang <unrealhoang@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 22, 2019

Build succeeded

@bors bors bot merged commit 079ed60 into rust-lang:master May 22, 2019
@unrealhoang unrealhoang deleted the move_arm_cond_to_match_guard branch May 22, 2019 08:01
@matklad matklad mentioned this pull request Aug 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

@edwin0cheng edwin0cheng edwin0cheng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unrealhoang @matklad @edwin0cheng