feat: Display the value of enum variant on hover #12966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
reviewed
Sep 12, 2022
|
Thanks! |
|
☀️ Test successful - checks-actions |
|
Note for the changelog, this PR is two features really, const eval support for enum variants (enabling hover to work better for enum variant constants), but imo more important, we now do inference in enum variant bodies |
bors
added a commit
that referenced
this pull request
Sep 20, 2022
Properly set the enum variant body type from the repr attribute Follow up for #12966, fixes some type inference problems
This was referenced Sep 24, 2022
bors
added a commit
that referenced
this pull request
Sep 24, 2022
Fix diagnostics not working in enum variant bodies cc #12966
|
Did I break this? 😅
|
|
That is not a valid expression, the variant is missing a cast. Though clearly we shouldn't leak the HIR representation on hover if we fail computation 😬 |
|
Weird, I actually checked that it compiled, but now it doesn't. Maybe I didn't save.. And you're right, of course, it does need a cast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12955
This PR adds const eval support for enums, as well as showing their value on hover, just as consts currently have.
I developed these two things at the same time, but I've realized now that they are separate. However since the hover is just a 10 line change (not including tests), I figured I may as well put them in the same PR. Though if you want them split up into "enum const eval support" and "show enum variant value on hover", I think that's reasonable too.
Since this adds const eval support for enums this also allows consts that reference enums to have their values computed now too.
The const evaluation itself is quite rudimentary, it doesn't keep track of the actual type of the enum, but it turns out that Rust doesn't actually either, and
E::A as u8is valid regardless of therepronE.It also doesn't really care about what expression the enum variant contains, it could for example be a string, despite that not being allowed, but I guess it's up to the
cargo checkdiagnostics to inform of such issues anyway?