minor: sync from downstream #13924
Merged
minor: sync from downstream #13924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix the same typo in a bunch of other places
RefCell::get_mut: fix typo and fix the same typo in a bunch of other places
Merge commit '368e0bb32f1178cf162c2ce5f7e10b7ae211eb26'
rustbot
added
the
S-waiting-on-review
|
r? @arcnmx |
|
Umm, these changes don't look right, where did they come from? |
|
I think I'm running into the same issue as in #13459, so I must be doing something really wrong :(. |
|
Okay, I think it's fine now? |
|
r? @Veykril Want to merge this so we unblock the other PRs? |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Seeing this just now, do you remember what you did that went wrong and what you did to make it right? I see a "merge master into sync-from-rust" between the two comments but not sure what the timeline is exactly. |
|
Not very well, but I think it was something really mundane like starting from a stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.