Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show type alias layout #14748

Merged
merged 1 commit into from
May 6, 2023
Merged

Conversation

lumenian
Copy link
Contributor

@lumenian lumenian commented May 6, 2023

This PR expands on #13490 to allow displaying layout data on hover for type aliases.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2023
@HKalbasi
Copy link
Member

HKalbasi commented May 6, 2023

Not necessarily a blocker for this PR, but I would like to have a hover config for disabling these before adding more of them. Can you add this config?

@lumenian
Copy link
Contributor Author

lumenian commented May 6, 2023

Not necessarily a blocker for this PR, but I would like to have a hover config for disabling these before adding more of them. Can you add this config?

Sure, will do in a separate PR tomorrow.

@HKalbasi
Copy link
Member

HKalbasi commented May 6, 2023

@bors r+

@bors
Copy link
Contributor

bors commented May 6, 2023

📌 Commit ecc081d has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 6, 2023

⌛ Testing commit ecc081d with merge a10fd83...

@bors
Copy link
Contributor

bors commented May 6, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing a10fd83 to master...

@bors bors merged commit a10fd83 into rust-lang:master May 6, 2023
@lnicola lnicola changed the title Show type alias layout feat: Show type alias layout May 7, 2023
@lnicola lnicola changed the title feat: Show type alias layout fix: Show type alias layout May 7, 2023
bors added a commit that referenced this pull request May 7, 2023
Add config for disabling hover memory layout data

Requested in #14748 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants