Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add Configuration for Progress Reporting Verbosity #16700

Conversation

davidbarsky
Copy link
Contributor

At work, some of the indexing would take up the entire status bar because of buck-out has some pretty long paths. This is an option to make it less chatty/loud.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2024
--
Configures the level of detail rust-analyzer will report while scanning files.

If not set, this will default to including parent directories while scanning.
Copy link
Member

@lnicola lnicola Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit confusing (I'd expect [] to mean that nothing is reported, with null being the default).

But I also don't see what makes it behave like the docs say (that is, report the directories when this is set to []).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah crud, I think I got the options here flipped. Lemme fix that.

@Veykril
Copy link
Member

Veykril commented Feb 28, 2024

This feels like a very odd config to me I have to say 😅 Does VSCode hide elements in the status bar if the messages are too long? (As in does it overflow into other elements?)

@davidbarsky
Copy link
Contributor Author

This feels like a very odd config to me I have to say 😅 Does VSCode hide elements in the status bar if the messages are too long?

It is a weird config, I agree.

As in does it overflow into other elements?

Yeah, it overflows and flashes in a weird, somewhat unpleasant way. This config working around that.

@Veykril
Copy link
Member

Veykril commented Feb 28, 2024

Ugh, I wonder if we can override the handling in the client code and just filter too long ones / replace the middle or something with ... to get below a character limit.

Edit: Looks like there is a handleWorkDoneProgress hook

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2024
@bors
Copy link
Contributor

bors commented Mar 5, 2024

☔ The latest upstream changes (presumably #16662) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril
Copy link
Member

Veykril commented Apr 18, 2024

So I am still not on board with the idea of a config for this honestly speaking, not sure what to do here.

Though now I'm wondering, are you saying absolute paths in there? Or are your projects just that deep that the paths relative to the project root are very long? If they are absolute than that sounds like we have a mismatch between paths and the project root path for you here.

@Veykril Veykril marked this pull request as draft April 18, 2024 09:21
@davidbarsky
Copy link
Contributor Author

So I am still not on board with the idea of a config for this honestly speaking, not sure what to do here.

Though now I'm wondering, are you saying absolute paths in there? Or are your projects just that deep that the paths relative to the project root are very long? If they are absolute than that sounds like we have a mismatch between paths and the project root path for you here.

I completely forgot about this PR!

Or are your projects just that deep that the paths relative to the project root are very long?

It's this one. The paths easily extend beyond 100 characters and it leads to a lot of flashing in the status bar. It's generally not an issue with something like ~/.cargo/bin/registry, but proc macros under Buck have some pretty deeply nested paths.

@Veykril
Copy link
Member

Veykril commented May 13, 2024

I wonder if we should just do the easy thing and truncate the paths to some arbitrary length (counting from the end of the path)?

@Veykril
Copy link
Member

Veykril commented Jun 11, 2024

I'll close this for now, this does not feel like something we'd want to have configuration for

@Veykril Veykril closed this Jun 11, 2024
@davidbarsky davidbarsky deleted the david/less-obstrusive-indexing-notifications branch November 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-decision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants