-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Add Configuration for Progress Reporting Verbosity #16700
config: Add Configuration for Progress Reporting Verbosity #16700
Conversation
-- | ||
Configures the level of detail rust-analyzer will report while scanning files. | ||
|
||
If not set, this will default to including parent directories while scanning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a bit confusing (I'd expect []
to mean that nothing is reported, with null
being the default).
But I also don't see what makes it behave like the docs say (that is, report the directories when this is set to []
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah crud, I think I got the options here flipped. Lemme fix that.
This feels like a very odd config to me I have to say 😅 Does VSCode hide elements in the status bar if the messages are too long? (As in does it overflow into other elements?) |
It is a weird config, I agree.
Yeah, it overflows and flashes in a weird, somewhat unpleasant way. This config working around that. |
Ugh, I wonder if we can override the handling in the client code and just filter too long ones / replace the middle or something with Edit: Looks like there is a |
☔ The latest upstream changes (presumably #16662) made this pull request unmergeable. Please resolve the merge conflicts. |
So I am still not on board with the idea of a config for this honestly speaking, not sure what to do here. Though now I'm wondering, are you saying absolute paths in there? Or are your projects just that deep that the paths relative to the project root are very long? If they are absolute than that sounds like we have a mismatch between paths and the project root path for you here. |
I completely forgot about this PR!
It's this one. The paths easily extend beyond 100 characters and it leads to a lot of flashing in the status bar. It's generally not an issue with something like |
I wonder if we should just do the easy thing and truncate the paths to some arbitrary length (counting from the end of the path)? |
I'll close this for now, this does not feel like something we'd want to have configuration for |
At work, some of the indexing would take up the entire status bar because of
buck-out
has some pretty long paths. This is an option to make it less chatty/loud.