Better inline preview for postfix completion #17073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Apr 15, 2024
|
Thanks! |
|
☀️ Test successful - checks-actions |
davidbarsky
added a commit
to davidbarsky/rust-analyzer
that referenced
this pull request
Apr 15, 2024
bors
added a commit
that referenced
this pull request
Apr 16, 2024
Revert #17073: Better inline preview for postfix completion See discussion on #17077, but I strongly suspect that the changes to the `TextEdit` ranges caused VS Code's autocomplete to prefer the snippets over method completions. I explain why I think that [here](#17077 (comment)).
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 17, 2024
…kril Revert rust-lang#17073: Better inline preview for postfix completion See discussion on rust-lang#17077, but I strongly suspect that the changes to the `TextEdit` ranges caused VS Code's autocomplete to prefer the snippets over method completions. I explain why I think that [here](rust-lang#17077 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better inline preview for postfix completion, a proper implementation of c5686c8.
Here editors may filter completion item with the text within
delete_range, so we need to include thereceiver textin thelookup(akaFilterTextin LSP spec) for editors to find the completion item. (See #17036 (comment), Thanks to pascalkuthe)