Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different error code of "no such field" error based on variant type #17131

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

bzy-debug
Copy link

fix #17107

Pass variant information down to diagnostic, so that we can get different error code based on variant type.

After fix:

  • structure

    Screenshot 2024-04-23 at 21 03 27
  • enum's structure variant

    Screenshot 2024-04-23 at 21 04 41

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2024
@bzy-debug bzy-debug changed the title different error code based on variant different error code of "no such field" error based on variant type Apr 23, 2024
Copy link
Member

@Young-Flash Young-Flash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lnicola
Copy link
Member

lnicola commented Apr 24, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2024

📌 Commit 5c88e98 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 24, 2024

⌛ Testing commit 5c88e98 with merge 73a4275...

@bors
Copy link
Contributor

bors commented Apr 24, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 73a4275 to master...

@bors bors merged commit 73a4275 into rust-lang:master Apr 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error code for 'no such field' not corrsponding to rustc
5 participants