fix: Fix implicit ty args being lowered where they shouldn't #17175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
commented
May 2, 2024
| @@ -662,7 +662,7 @@ impl<'a> Ctx<'a> { | |||
| let attrs = RawAttrs::new(self.db.upcast(), ¶m, self.body_ctx.span_map()); | |||
| debug_assert!(self.generic_param_attr_buffer.insert(item, attrs).is_none()); | |||
| }; | |||
|
|
|||
| self.body_ctx.take_impl_traits_bounds(); | |||
There was a problem hiding this comment.
Issue was basically this line missing. Without it, we start allocating impl trait args for things that are not related to the generic params / where clauses
|
cc @dfireBird this fixes an issue that your recent PR introduced just so you are aware |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
May 19, 2024
Fix impl trait params not being counted properly Fixes the other thing in rust-lang/rust-analyzer#17173, this just rolls back a change from rust-lang/rust-analyzer#17175 and adds a comment as to what it does
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17173