Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add landing/faq walkthrough pages #17508

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

jjoeldaniel
Copy link
Contributor

@jjoeldaniel jjoeldaniel commented Jun 28, 2024

This is a basic implementation of a landing and FAQ page; I've included the bare-bones information as well as a recommended section on inlay hints.

I've also added rust-analyzer: Open Walkthrough and rust-analyzer: Open FAQ commands for ease of access.

I am hoping to create a small list of FAQ to include that might be useful as well as any other information I may have missed in the landing page. Feel free to share any suggestions!

landing/faq page demo

cc #13351

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2024
@jjoeldaniel jjoeldaniel marked this pull request as ready for review July 5, 2024 17:06
@Veykril
Copy link
Member

Veykril commented Jul 6, 2024

Thanks! Edited the description to not close the linked issue as I think there is more we can do here.
@bors r+

@bors
Copy link
Contributor

bors commented Jul 6, 2024

📌 Commit 5749764 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 6, 2024

⌛ Testing commit 5749764 with merge 78d5f05...

@bors
Copy link
Contributor

bors commented Jul 6, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 78d5f05 to master...

@bors bors merged commit 78d5f05 into rust-lang:master Jul 6, 2024
1 check passed
@jjoeldaniel jjoeldaniel deleted the landing-page branch July 6, 2024 22:16
bors added a commit that referenced this pull request Jul 19, 2024
internal: remove rust-analyzer.openFAQ

Removed no longer functional `rust-analyzer.openFAQ` command created in #17508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants