Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about neovim's built in language server #2370

Merged
merged 2 commits into from
Nov 23, 2019

Conversation

norcalli
Copy link
Contributor

@norcalli norcalli commented Nov 23, 2019

I implemented a builtin language server client (:h lsp.txt) for neovim and it's been in master since 2019-11-13. We built https://github.com/neovim/nvim-lsp to contain easy configuration settings for servers which we hope to be a database that can be referenced for other editors/3rd party users as well.

Support will be merged very soon neovim/nvim-lspconfig#43.

@matklad
Copy link
Member

matklad commented Nov 23, 2019

bors r+

Oups, I've forgot to actually answer your issue, let me take a minute to do so...

@norcalli
Copy link
Contributor Author

That's fine. I forgot I made an issue, lol. #2344 for reference.

bors bot added a commit that referenced this pull request Nov 23, 2019
2370: Add note about neovim's built in language server r=matklad a=norcalli

I implemented a builtin language server client (`:h lsp.txt`) for neovim and it's been in master since 2019-11-13. We built https://github.com/neovim/nvim-lsp to contain easy configuration settings for servers which we hope to be a database that can be referenced for other editors/3rd party users as well.

Support will be merged very soon neovim/nvim-lspconfig#43.

Co-authored-by: Ashkan Kiani <ashkan.k.kiani@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 23, 2019

Build succeeded

  • Rust
  • TypeScript

@bors bors bot merged commit ebdde64 into rust-lang:master Nov 23, 2019
@oblitum
Copy link
Contributor

oblitum commented Dec 16, 2019

I think this doc addition is mixed up with the coc.nvim setup, which can cause confusion. The way it reads may look like for someone that will go the coc.nvim route that it needs to setup nvim-lsp. It's a bit messy. This is just a viewpoint, I'm not endorsing for any info remotion, just better rearrangement. As of now coc.nvim is the easier route, and works both in Vim and NeoVim, while nvim-lsp can work only on NeoVim master, and doesn't work right out of the box.

@norcalli norcalli deleted the patch-1 branch December 16, 2019 22:52
@norcalli
Copy link
Contributor Author

norcalli commented Dec 16, 2019

@oblitum small nit nvim-lsp does work out of the box, and technically you have to install coc and also the coc rust analyzer plugin, if we're splitting hairs, then that's the same number of steps as installing neovim master and installing nvim-lsp.

I don't have any opinion on the wording, though.

@oblitum
Copy link
Contributor

oblitum commented Dec 16, 2019

@norcalli that's not the main point regarding the docs, but, does it have, for example, completion/signatureHelp working without having to set any mappings? Because that's what you get just by installing coc.nvim, no additional mapping setup, etc.

@norcalli
Copy link
Contributor Author

norcalli commented Dec 16, 2019

@oblitum specifically signatureHelp hasn't been added yet, but it will be in due time. Again, though, splitting hairs. Actually that's not true. It was added, it's just not automatically triggered. Because coc.nvim is a plugin, it can choose do more opinionated things, whereas anything in core has to take a more measured response. But in all likelihood, I will just make it trigger automatically eventually. I just haven't gotten around to it yet because I started a new job this last month.

@oblitum
Copy link
Contributor

oblitum commented Dec 16, 2019

@norcalli I didn't get what you mean on what's not true. As out-of-the-box I just understand one thing, whether you get, at least, completion/signatureHelp without any additional configuration. That's what I meant. If nvim-lsp provides that, then OK, I withdraw my statement, otherwise not. It doesn't matter for what reason nvim-lsp doesn't do it. Just like to point that's not the issue here, so I prefer not have focus on it here. The current issue regards the docs merged not being very clear.

@oblitum
Copy link
Contributor

oblitum commented Dec 17, 2019

I don't have any opinion on the wording, though.

I didn't track that comment change. Well, to illustrate and trying to be more specific, this nvim-lsp comment has been added to a "Vim and NeoVim" section, while there's even an "Alternative" section already, that again, covers both. This addition could be separated on some NeoVim only section. The other issue as already mentioned is that it's a paragraph that sits above the steps for coc.nvim setup, which may look confusing.

@matklad
Copy link
Member

matklad commented Dec 17, 2019

Opened #2579. I think we indeed need a more structured discussion of alternatives, which ideally doesn't try to figure out which one is better -- thats for user to decide :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants