Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support macro for trait items #4283

Merged
merged 3 commits into from
May 4, 2020
Merged

Conversation

edwin0cheng
Copy link
Member

Fixed #4039

r? @flodiebold

Copy link
Member

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice diff!

crates/ra_hir_def/src/data.rs Outdated Show resolved Hide resolved
@matklad
Copy link
Member

matklad commented May 4, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented May 4, 2020

@bors bors bot merged commit 57f285d into rust-lang:master May 4, 2020
@edwin0cheng edwin0cheng deleted the trait-items-macro branch May 4, 2020 10:59
bors bot added a commit that referenced this pull request May 5, 2020
4321: Rename ImplItem to AssocItem r=matklad a=edwin0cheng

Related discussion: #4283 (comment)

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support macro expansion of trait items
3 participants