Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't underline function definition if self is &mut #5823

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Aug 19, 2020

The self is right there, and is already underlined, so it makes little
sense to emit even more underlines.

before:
before
after:
after

The self is right there, and is already underlined, so it makes little
sense to emit even more underlines.
@matklad
Copy link
Member Author

matklad commented Aug 19, 2020

bors d=@Nashenas88

@bors
Copy link
Contributor

bors bot commented Aug 19, 2020

✌️ Nashenas88 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Nashenas88
Copy link
Contributor

I had the same idea regarding unsafe as well (the fn name is highlighted as unsafe, when it's really not needed since the unsafe keyword is two tokens behind the fn name, and creating an unsafe fn isn't an unsafe operation). Should I add that change here as well or as a follow-up?

@matklad
Copy link
Member Author

matklad commented Aug 21, 2020

Hm, not sure about unsafe.... Given that unsafe differs only in color (and not in decaorations), the difference doesn't seem as jarring there...

@Nashenas88
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 22, 2020

@bors bors bot merged commit e65d48d into rust-lang:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants