Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for extra env vars in the Code extension #7091

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Dec 30, 2020

I was debugging some issues with the RA extension around getting cargo check to work and it was particularly frustrating to get the RA_LOG variable set on the server since I had to change it in a login file. This should make that easier.

@@ -283,6 +283,14 @@
"default": null,
"markdownDescription": "Path to rust-analyzer executable (points to bundled binary by default). If this is set, then `#rust-analyzer.updates.channel#` setting is not used"
},
"rust-analyzer.serverExtraEnv": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rust-analyzer.serverExtraEnv": {
"rust-analyzer.server.extraEnv": {

we'll migrate serverPath later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed 👍🏻

Copy link
Member

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with config renamed

bors d+

@bors
Copy link
Contributor

bors bot commented Dec 30, 2020

✌️ lf- can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@lf-
Copy link
Contributor Author

lf- commented Dec 30, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 30, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants