fix: Annotate type hints for pattern name ranges instead of the pattern itself #9744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
force-pushed
the
inlay-hints-ident
branch
from
a4cd730
to
f7c7f89
Compare
matklad
approved these changes
Jul 31, 2021
| @@ -194,8 +194,12 @@ fn get_bind_pat_hints( | |||
| if should_not_display_type_hint(sema, &pat, &ty) { | |||
| return None; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
👍 always nice to give the code room to breathe!
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current type hints do not go well with
bindings_after_atwhich is likely to land with 1.56(rust-lang/rust#85305 🎉very excited for this), hence annotate the names of ident patterns instead of the entire pattern.This changes where the typehints go for ident patterns that use @ bindings, some example comparisons:
Before:
After:
This change has no visible effect on patterns without
@bindings.