For compatibility, just keep deriving Default for all opaque types

rust-lang · Aug 9, 2024 · 95d8d58 · 95d8d58
1 parent 9d58571
commit 95d8d58
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 57 deletions.
diff --git a/bindgen-tests/tests/expectations/tests/libclang-9/issue-544-stylo-creduce-2.rs b/bindgen-tests/tests/expectations/tests/libclang-9/issue-544-stylo-creduce-2.rs
diff --git a/bindgen-tests/tests/expectations/tests/non-type-params.rs b/bindgen-tests/tests/expectations/tests/non-type-params.rs
diff --git a/bindgen-tests/tests/expectations/tests/nsBaseHashtable.rs b/bindgen-tests/tests/expectations/tests/nsBaseHashtable.rs
diff --git a/bindgen-tests/tests/expectations/tests/partial-specialization-and-inheritance.rs b/bindgen-tests/tests/expectations/tests/partial-specialization-and-inheritance.rs
diff --git a/bindgen-tests/tests/expectations/tests/size_t_template.rs b/bindgen-tests/tests/expectations/tests/size_t_template.rs
diff --git a/bindgen-tests/tests/expectations/tests/va_list_aarch64_linux.rs b/bindgen-tests/tests/expectations/tests/va_list_aarch64_linux.rs
diff --git a/bindgen/codegen/mod.rs b/bindgen/codegen/mod.rs
@@ -5448,16 +5448,9 @@ pub(crate) mod utils {
         let ty = quote! {
             /// If Bindgen could only determine the size and alignment of a
             /// type, it is represented like this.
-            #[derive(PartialEq, Copy, Clone, Hash, Debug)]
+            #[derive(PartialEq, Copy, Clone, Debug, Default, Hash)]
             #[repr(C)]
             pub struct __BindgenOpaqueArray<T, const N: usize>(pub [T; N]);
-            /// `Default` is only implemented for zero-sized opaque types, since
-            /// Bindgen does not know what contents make sense as a default.
-            impl<T> Default for __BindgenOpaqueArray<T, 0> {
-                fn default() -> Self {
-                    Self([])
-                }
-            }
         };
 
         result.insert(0, ty);

diff --git a/bindgen/ir/ty.rs b/bindgen/ir/ty.rs
@@ -582,7 +582,7 @@ pub(crate) enum TypeKind {
     /// A compound type, that is, a class, struct, or union.
     Comp(CompInfo),
 
-    /// An opaque type that we just don't understand. All usage of this shoulf
+    /// An opaque type that we just don't understand. All usage of this should
     /// result in an opaque blob of bytes generated from the containing type's
     /// layout.
     Opaque,