Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite is_unsized as a fix-point analysis #768

Closed
fitzgen opened this issue Jun 19, 2017 · 0 comments · Fixed by #1102
Closed

Rewrite is_unsized as a fix-point analysis #768

fitzgen opened this issue Jun 19, 2017 · 0 comments · Fixed by #1102
Labels
E-less-easy help wanted I-cleanup

Comments

@fitzgen
Copy link
Member

fitzgen commented Jun 19, 2017 •
edited
Loading

See #536 for details.

This is very similar to when we re-wrote has_destructor to a fixed-point analysis, and that PR could be used to guide fixing this issue: #850
@fitzgen fitzgen mentioned this issue Jun 19, 2017
Closed
6 tasks
@fitzgen fitzgen removed the C-assigned label Sep 8, 2017
@fitzgen fitzgen changed the title Rewrite is_unsized as either a graph traversal or fix-point analysis Rewrite is_unsized as a fix-point analysis Sep 8, 2017
@rust-lang rust-lang deleted a comment from tz70s Sep 8, 2017
@rust-lang rust-lang deleted a comment from tz70s Sep 8, 2017
@rust-lang rust-lang deleted a comment from tz70s Sep 8, 2017
@fitzgen fitzgen mentioned this issue Oct 25, 2017
Merged
fitzgen added a commit to fitzgen/rust-bindgen that referenced this issue Oct 25, 2017
@fitzgen
Compute sizedness with a fixed-point analysis
e7622f9 
This fixes a couple bugs where we weren't properly adding an `_address`
byte. It also helps pave the way for computing implicit fields (such as padding,
`_address`, vtable pointers, etc) in its own pass, before codegen.

Fixes rust-lang#768
fitzgen added a commit to fitzgen/rust-bindgen that referenced this issue Oct 25, 2017
@fitzgen
Compute sizedness with a fixed-point analysis
379bb16 
This fixes a couple bugs where we weren't properly adding an `_address`
byte. It also helps pave the way for computing implicit fields (such as padding,
`_address`, vtable pointers, etc) in its own pass, before codegen.

Fixes rust-lang#768
bors-servo pushed a commit that referenced this issue Oct 25, 2017
Auto merge of #1102 - fitzgen:sizedness, r=pepyakin
88a1e24 
Compute sizedness with a fixed-point analysis

This fixes a couple bugs where we weren't properly adding an `_address` byte. It also helps pave the way for computing implicit fields (such as padding, `_address`, vtable pointers, etc) in its own pass, before codegen.

Fixes #768

r? @pepyakin
bors-servo pushed a commit that referenced this issue Oct 25, 2017
Auto merge of #1102 - fitzgen:sizedness, r=pepyakin
1cb1101 
Compute sizedness with a fixed-point analysis

This fixes a couple bugs where we weren't properly adding an `_address` byte. It also helps pave the way for computing implicit fields (such as padding, `_address`, vtable pointers, etc) in its own pass, before codegen.

Fixes #768

r? @pepyakin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-less-easy help wanted I-cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compute sizedness with a fixed-point analysis fitzgen/rust-bindgen
1 participant
@fitzgen