Fixed all compilation issues, and renamed fail/fail.rs to panic/panic.rs #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make all:
* Changed all `fail!()`s to `panic!()`s
* Changed current working directory to unwrap the result
make clean: Changed `rm -rf {bin,stage}` (which doesn't work) to
`rm -rf bin stage`
makefile:
* Changed lints to be correct
* unused-variable -> unused-variables
* dead-assignment -> unused-assignments
rust files:
* Changed fail!() calls to panic!() calls
* Changed some syntax so that slices are correct
* i.e. in array.rs (analyze_slice(xs) -> analyze_slice(&xs))
* Namespaced enums
* Renamed `Node` to `List` in enum.rs
* Renamed List::append() to List::prepend(), which is the actual
operation that is taking place
* Renamed fail/fail.rs to panic/panic.rs
* And everything that comes with that
* Changed any `{:t}`s to `{:b}`s
* `use`d std::num::Float in places that needed it
* In fmt/show.rs, changed {:.3f} to {:.3}
* Changed hash table .find() to .get()
* Took out the parens in a string .get(), so that
`h.get(&("string"))` becomes `h.get(&"string")`
* Completely removed smallintmap
* In json/decodable/decodable.rs, changed {:.2f} to {:.2}
* In src/file.rs, changed a comment to be under 79 characters long
|
Oh, and something that I forgot to write: I have also explained namespaced enums. |
brson
added a commit
that referenced
this pull request
Dec 2, 2014
Fixed all compilation issues, and renamed fail/fail.rs to panic/panic.rs
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.