Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICE when running clippy on 'criner' #5389

Closed
Byron opened this issue Mar 30, 2020 · 1 comment · Fixed by #5709
Closed

ICE when running clippy on 'criner' #5389

Byron opened this issue Mar 30, 2020 · 1 comment · Fixed by #5709
Labels
I-ICE Issue: Clippy panicked, giving an Internal Compilation Error (ICE) ❄️

Comments

@Byron
Copy link
Member

Byron commented Mar 30, 2020

How to reproduce

git clone https://github.com/the-lean-crate/criner
cd criner
git checkout ee36740dc0e91b2097ed74b9ec0946a2c372298b
RUST_BACKTRACE=1 cargo clippy

Results in…

[…]
error: internal compiler error: src/librustc/ty/context.rs:526: node_type: no type for node `expr 128 (hir_id=HirId { owner: DefIndex(1025), local_id: 603 })`

Meta

MacOS 10.15

➜  criner git:(master) ✗ cargo clippy -V
clippy 0.0.212 (4ee12063 2020-02-01)
Full Backtrace
[…]
error: internal compiler error: src/librustc/ty/context.rs:526: node_type: no type for node `expr 128 (hir_id=HirId { owner: DefIndex(1025), local_id: 603 })`

thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:873:9
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::default_hook
   5: clippy_driver::report_clippy_ice
   6: std::panicking::rust_panic_with_hook
   7: std::panicking::begin_panic
   8: rustc_errors::HandlerInner::bug
   9: rustc_errors::Handler::bug
  10: rustc::util::bug::opt_span_bug_fmt::{{closure}}
  11: rustc::ty::context::tls::with_opt::{{closure}}
  12: rustc::ty::context::tls::with_opt
  13: rustc::util::bug::opt_span_bug_fmt
  14: rustc::util::bug::bug_fmt
  15: rustc::ty::context::TypeckTables::node_type::{{closure}}
  16: rustc::ty::context::TypeckTables::expr_ty
  17: clippy_lints::consts::ConstEvalLateContext::expr
  18: clippy_lints::consts::constant_simple
  19: clippy_lints::utils::hir_utils::SpanlessEq::eq_expr
  20: <clippy_lints::loops::InitializeVisitor as rustc_hir::intravisit::Visitor>::visit_expr
  21: <clippy_lints::loops::InitializeVisitor as rustc_hir::intravisit::Visitor>::visit_expr
  22: <clippy_lints::loops::InitializeVisitor as rustc_hir::intravisit::Visitor>::visit_stmt
  23: clippy_lints::loops::check_for_loop
  24: <clippy_lints::loops::Loops as rustc_lint::passes::LateLintPass>::check_expr
  25: <rustc_lint::late::LateLintPassObjects as rustc_lint::passes::LateLintPass>::check_expr
  26: <rustc_lint::late::LateContextAndPass<T> as rustc_hir::intravisit::Visitor>::visit_expr
  27: <rustc_lint::late::LateContextAndPass<T> as rustc_hir::intravisit::Visitor>::visit_expr
  28: rustc_hir::intravisit::walk_block
  29: rustc_hir::intravisit::walk_expr
  30: <rustc_lint::late::LateContextAndPass<T> as rustc_hir::intravisit::Visitor>::visit_expr
  31: rustc_hir::intravisit::walk_fn
  32: rustc_hir::intravisit::walk_item
  33: rustc_hir::intravisit::Visitor::visit_nested_item
  34: rustc_hir::intravisit::walk_item
  35: rustc_hir::intravisit::Visitor::visit_nested_item
  36: rustc_hir::intravisit::walk_item
  37: rustc_hir::intravisit::Visitor::visit_nested_item
  38: rustc_hir::intravisit::walk_item
  39: rustc_hir::intravisit::Visitor::visit_nested_item
  40: rustc_hir::intravisit::walk_crate
  41: rustc_lint::late::late_lint_pass_crate
  42: rustc_session::utils::<impl rustc_session::session::Session>::time
  43: __rust_maybe_catch_panic
  44: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
  45: __rust_maybe_catch_panic
  46: rustc_session::utils::<impl rustc_session::session::Session>::time
  47: rustc_interface::passes::analysis
  48: rustc::ty::query::__query_compute::analysis
  49: rustc::dep_graph::graph::DepGraph::with_task_impl
  50: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
  51: rustc::ty::context::tls::enter_global
  52: rustc_interface::interface::run_compiler_in_existing_thread_pool
  53: scoped_tls::ScopedKey<T>::set
  54: syntax::with_globals
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

note: Clippy version: clippy 0.0.212 (4ee12063 2020-02-01)

query stack during panic:
#0 [analysis] running analysis passes on this crate
end of query stack
error: aborting due to previous error
@matthiaskrgr matthiaskrgr added the I-ICE Issue: Clippy panicked, giving an Internal Compilation Error (ICE) ❄️ label Mar 30, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

Here is a simple reproducer:

fn main() {
    let v = vec![1, 2, 3];
    let mut i = 0;
    let max_storage_size = [0; 128 * 1024];
    for item in &v {
        bar(i, *item);
        i += 1;
    }
}

fn bar(_:usize, _:u32) {
    
}

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=4e47cb10e696e78d73ae73c61037116a

bors added a commit that referenced this issue Jun 12, 2020
Fix ICE in consts::binop

changelog: Fix ICE in `consts::binop`

Fixes #5389
@bors bors closed this as completed in 9505919 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-ICE Issue: Clippy panicked, giving an Internal Compilation Error (ICE) ❄️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants