Clippy doesn't catch Result<T,E>.map_or(None, Some(T))
#5414
Comments
6 tasks
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this issue
Apr 7, 2020
Add new lint for `Result<T, E>.map_or(None, Some(T))` Fixes rust-lang#5414 PR Checklist --- - [x] Followed lint naming conventions (the name is a bit awkward, but it seems to conform) - [x] Added passing UI tests (including committed .stderr file) - [x] cargo test passes locally - [x] Executed cargo dev update_lints - [x] Added lint documentation - [x] Run cargo dev fmt `Result<T, E>` has an [`ok()`](https://doc.rust-lang.org/std/result/enum.Result.html#method.ok) method that adapts a `Result<T,E>` into an `Option<T>`. It's possible to get around this adapter by writing `Result<T,E>.map_or(None, Some)`. This lint is implemented as a new variant of the existing [`option_map_none` lint](rust-lang#2128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Result<T,E>has a method to adapt into anOption<T>, Clippy doesn't catch attempts to rewrite this method asResult<T,E>.map_or(None, Some(T))The text was updated successfully, but these errors were encountered: