Do not lint when imported item contains underscore #10300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
Hey, I've seen this PR, but had a pretty busy week so far. I'll review this tomorrow or on Friday, the latest! :) |
xFrednet
reviewed
Feb 10, 2023
rustbot
added
S-waiting-on-author
|
I'm closing this PR due to inactivity. Hope you'll get better soon @koka831! Anyone else reading this, feel free to continue this PR. I believe it was only one or two questions remaining. |
xFrednet
added
S-inactive-closed
xFrednet
approved these changes
Sep 25, 2023
koka831
commented
Sep 26, 2023
|
@xFrednet thank you for your comment. now I think I've addressed them. could you review again please? |
xFrednet
approved these changes
Sep 26, 2023
|
Looks good to me, thank you for coming back and updating this PR :D |
xFrednet
added
S-waiting-on-author
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9942
changelog: [
wildcard_imports]: No longer lints when imported items contain an item with the name_