Add configuration to lint missing docs of pub(crate) items

[pvdrz]

Fixes this: #5736 (comment)

TODO:

• Needs docs
• Needs better names
• Should pub items be checked to when this new option is enabled? I'm saying no because missing_docs already exists

@flip1995 I'd like to get some input from you :)

---

changelog: Enhancement: [missing_docs_in_private_items]: Added new configuration missing-docs-in-crate-items to lint on items visible within the current crate. For example, pub(crate) items.
#10303

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information.

[flip1995]

• Should pub items be checked to when this new option is enabled? I'm saying no because missing_docs already exists

Agreed. I also am fine with the name. I'll let @giraffate do the final review, I only skimmed over the name and documentation.

[giraffate]

Thanks! I asked one question.

The tests/ui-toml/pub_crate_missing_docs/pub_crate_missing_doc.stdout file is empty, so it should be removed.

[giraffate]

Overall looks good, thanks!

I made small comments. I'll merge this once those are addressed.

[pvdrz]

Thanks @giraffate! It seems we're good to go then

[giraffate]

@bors r+

Thanks!

[bors]

📌 Commit 790f28b has been approved by giraffate

It is now in the queue for this repository.

[bors]

⌛ Testing commit 790f28b with merge b1cf1e7...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing b1cf1e7 to master...