Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninlined_format_args: do not inline argument with generic parameters #10343

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Feb 13, 2023

Fix #10339


changelog: FP: [uninlined_format_args]: No longer lints for arguments with generic parameters
#10343

@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 13, 2023
Copy link
Contributor

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@nyurik
Copy link
Contributor

nyurik commented Feb 15, 2023

Should this be tagged as a false positive?
cc: @Alexendoo as an expert in format args

@samueltardieu samueltardieu changed the title unlined_format_args: do not inline argument with generic parameters uninlined_format_args: do not inline argument with generic parameters Feb 15, 2023
@samueltardieu
Copy link
Contributor Author

(refreshed to update the commit message, "unlined" → "uninlined")

@Alexendoo
Copy link
Member

Yeah it's a FP fix, added that to the changelog:

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 15, 2023

📌 Commit 75aa2b9 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 15, 2023

⌛ Testing commit 75aa2b9 with merge 8754d5a...

@bors
Copy link
Collaborator

bors commented Feb 15, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 8754d5a to master...

@bors bors merged commit 8754d5a into rust-lang:master Feb 15, 2023
@samueltardieu samueltardieu deleted the issue-10339 branch February 19, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uninlined_format_args ignores turbofish
6 participants